Re: [PATCH v5.5 05/30] KVM: Resync only arch fields when slots_arch_lock... | linux-arm-kernel

[PATCH v5.5 00/30] KVM: Scalable memslots implementation · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 01/30] KVM: Ensure local memslot copies operate on up-to-date arch-specific data · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 01/30] KVM: Ensure local memslot copies operate on up-to-date arch-specific data · Ben Gardon <hidden> · 2021-11-04
Re: [PATCH v5.5 01/30] KVM: Ensure local memslot copies operate on up-to-date arch-specific data · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 01/30] KVM: Ensure local memslot copies operate on up-to-date arch-specific data · Maciej S. Szmigiero <hidden> · 2021-11-09
Re: [PATCH v5.5 01/30] KVM: Ensure local memslot copies operate on up-to-date arch-specific data · Sean Christopherson <seanjc@google.com> · 2021-11-09
[PATCH v5.5 02/30] KVM: Disallow user memslot with size that exceeds "unsigned long" · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 02/30] KVM: Disallow user memslot with size that exceeds "unsigned long" · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 03/30] KVM: Require total number of memslot pages to fit in an unsigned long · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 03/30] KVM: Require total number of memslot pages to fit in an unsigned long · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 04/30] KVM: Open code kvm_delete_memslot() into its only caller · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 04/30] KVM: Open code kvm_delete_memslot() into its only caller · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 05/30] KVM: Resync only arch fields when slots_arch_lock gets reacquired · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 05/30] KVM: Resync only arch fields when slots_arch_lock gets reacquired · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 06/30] KVM: Use "new" memslot's address space ID instead of dedicated param · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 06/30] KVM: Use "new" memslot's address space ID instead of dedicated param · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 07/30] KVM: Let/force architectures to deal with arch specific memslot data · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 07/30] KVM: Let/force architectures to deal with arch specific memslot data · Maciej S. Szmigiero <hidden> · 2021-11-09
Re: [PATCH v5.5 07/30] KVM: Let/force architectures to deal with arch specific memslot data · Sean Christopherson <seanjc@google.com> · 2021-11-09
[PATCH v5.5 08/30] KVM: arm64: Use "new" memslot instead of userspace memory region · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 08/30] KVM: arm64: Use "new" memslot instead of userspace memory region · Reiji Watanabe <hidden> · 2021-11-09
[PATCH v5.5 09/30] KVM: MIPS: Drop pr_debug from memslot commit to avoid using "mem" · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 10/30] KVM: PPC: Avoid referencing userspace memory region in memslot updates · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 11/30] KVM: s390: Use "new" memslot instead of userspace memory region · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 12/30] KVM: x86: Use "new" memslot instead of userspace memory region · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 12/30] KVM: x86: Use "new" memslot instead of userspace memory region · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 13/30] KVM: RISC-V: Use "new" memslot instead of userspace memory region · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 14/30] KVM: Stop passing kvm_userspace_memory_region to arch memslot hooks · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 14/30] KVM: Stop passing kvm_userspace_memory_region to arch memslot hooks · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 15/30] KVM: Use prepare/commit hooks to handle generic memslot metadata updates · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 15/30] KVM: Use prepare/commit hooks to handle generic memslot metadata updates · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 16/30] KVM: x86: Don't assume old/new memslots are non-NULL at memslot commit · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 16/30] KVM: x86: Don't assume old/new memslots are non-NULL at memslot commit · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 17/30] KVM: s390: Skip gfn/size sanity checks on memslot DELETE or FLAGS_ONLY · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 18/30] KVM: Don't make a full copy of the old memslot in __kvm_set_memory_region() · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 18/30] KVM: Don't make a full copy of the old memslot in __kvm_set_memory_region() · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 19/30] KVM: x86: Don't call kvm_mmu_change_mmu_pages() if the count hasn't changed · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 20/30] KVM: x86: Use nr_memslot_pages to avoid traversing the memslots array · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 20/30] KVM: x86: Use nr_memslot_pages to avoid traversing the memslots array · Maciej S. Szmigiero <hidden> · 2021-11-09
Re: [PATCH v5.5 20/30] KVM: x86: Use nr_memslot_pages to avoid traversing the memslots array · Sean Christopherson <seanjc@google.com> · 2021-11-09
Re: [PATCH v5.5 20/30] KVM: x86: Use nr_memslot_pages to avoid traversing the memslots array · Maciej S. Szmigiero <hidden> · 2021-11-09
[PATCH v5.5 21/30] KVM: Integrate gfn_to_memslot_approx() into search_memslots() · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 22/30] KVM: Move WARN on invalid memslot index to update_memslots() · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 23/30] KVM: Resolve memslot ID via a hash table instead of via a static array · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 23/30] KVM: Resolve memslot ID via a hash table instead of via a static array · Maciej S. Szmigiero <hidden> · 2021-11-11
Re: [PATCH v5.5 23/30] KVM: Resolve memslot ID via a hash table instead of via a static array · Sean Christopherson <seanjc@google.com> · 2021-11-12
[PATCH v5.5 24/30] KVM: Use interval tree to do fast hva lookup in memslots · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 24/30] KVM: Use interval tree to do fast hva lookup in memslots · Maciej S. Szmigiero <hidden> · 2021-11-11
Re: [PATCH v5.5 24/30] KVM: Use interval tree to do fast hva lookup in memslots · Sean Christopherson <seanjc@google.com> · 2021-11-12
[PATCH v5.5 25/30] KVM: s390: Introduce kvm_s390_get_gfn_end() · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones · Maciej S. Szmigiero <hidden> · 2021-11-11
Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones · Sean Christopherson <seanjc@google.com> · 2021-11-12
Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones · Maciej S. Szmigiero <hidden> · 2021-11-13
[PATCH v5.5 27/30] KVM: Optimize gfn lookup in kvm_zap_gfn_range() · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 28/30] KVM: Optimize overlapping memslots check · Sean Christopherson <seanjc@google.com> · 2021-11-04
[PATCH v5.5 29/30] KVM: Wait 'til the bitter end to initialize the "new" memslot · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 29/30] KVM: Wait 'til the bitter end to initialize the "new" memslot · Maciej S. Szmigiero <hidden> · 2021-11-11
[PATCH v5.5 30/30] KVM: Dynamically allocate "new" memslots from the get-go · Sean Christopherson <seanjc@google.com> · 2021-11-04
Re: [PATCH v5.5 30/30] KVM: Dynamically allocate "new" memslots from the get-go · Maciej S. Szmigiero <hidden> · 2021-11-11
Re: [PATCH v5.5 30/30] KVM: Dynamically allocate "new" memslots from the get-go · Sean Christopherson <seanjc@google.com> · 2021-11-12
Re: [PATCH v5.5 00/30] KVM: Scalable memslots implementation · Maciej S. Szmigiero <hidden> · 2021-11-09
Re: [PATCH v5.5 00/30] KVM: Scalable memslots implementation · Sean Christopherson <seanjc@google.com> · 2021-11-09
Re: [PATCH v5.5 00/30] KVM: Scalable memslots implementation · Maciej S. Szmigiero <hidden> · 2021-11-11
Re: [PATCH v5.5 00/30] KVM: Scalable memslots implementation · Maciej S. Szmigiero <hidden> · 2021-11-23
Re: [PATCH v5.5 00/30] KVM: Scalable memslots implementation · Paolo Bonzini <pbonzini@redhat.com> · 2021-11-26

Re: [PATCH v5.5 05/30] KVM: Resync only arch fields when slots_arch_lock gets reacquired

From: Maciej S. Szmigiero <hidden>
Date: 2021-11-09 00:40:00
Also in: kvm, kvm-riscv, kvmarm, linux-mips, linux-riscv, lkml

On 04.11.2021 01:25, Sean Christopherson wrote:

From: Maciej S. Szmigiero <redacted>

There is no need to copy the whole memslot data after releasing
slots_arch_lock for a moment to install temporary memslots copy in
kvm_set_memslot() since this lock only protects the arch field of each
memslot.

Just resync this particular field after reacquiring slots_arch_lock.

Note, this also eliminates the need to manually clear the INVALID flag
when restoring memslots; the "setting" of the INVALID flag was an
unwanted side effect of copying the entire memslots.

Signed-off-by: Maciej S. Szmigiero <redacted>
[sean: tweak shortlog, note INVALID flag in changelog, revert comment]

This updated patch also open-codes kvm_copy_memslots(), which my
previous version didn't.
I think it's worth mentioning this in the change log, too.

Thanks,
Maciej

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help