Thread (44 messages) 44 messages, 8 authors, 2021-11-21

Re: [PATCH 03/13] arm: Kconfig.debug: drop reference to removed ARCH_MSM

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: 2021-11-02 07:55:23
Also in: kernel-janitors, lkml, openbmc

On Thu, Oct 28, 2021 at 4:42 PM Arnd Bergmann [off-list ref] wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
Commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM architecture
code") removes the definition of the config ARCH_MSM. Since then, the
reference to ARCH_MSM in the dependencies of UNCOMPRESS_INCLUDE in
Kconfig.debug is dead.

Fortunately, ./scripts/checkkconfigsymbols.py warns:

ARCH_MSM
Referencing files: arch/arm/Kconfig.debug

Drop the dependency on this removed config.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 83484564b1d9..87aa6e92ee6e 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1886,7 +1886,7 @@ config DEBUG_UNCOMPRESS

 config UNCOMPRESS_INCLUDE
        string
-       default "debug/uncompress.h" if ARCH_MULTIPLATFORM || ARCH_MSM || \
+       default "debug/uncompress.h" if ARCH_MULTIPLATFORM || \
                                        PLAT_SAMSUNG || ARM_SINGLE_ARMV7M
The PLAT_SAMSUNG reference is also misplaced here, I think you just want
ARCH_S3C24XX instead, since the other samsung ones already require
ARCH_MULTIPLATFORM.
Agree. I can clean up (or better stated: optimize) the dependencies
further in such a way. But that config dependency optimization goes
beyond just removing dead symbols and deserves to be its own patch.
Patch will follow later this week.

Lukas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help