Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-10-28 15:36:09
Also in:
kernel-janitors, lkml, openbmc
On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:quoted
Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef in ./arch/arm/kernel/bios32.c. Hence, ./scripts/checkkconfigsymbols.py warns: PCI_HOST_ITE8152 Referencing files: arch/arm/kernel/bios32.c Remove this obsolete ifndef. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>Reviewed-by: Arnd Bergmann <arnd@arndb.de> I wonder if we should just remove this function and use the (non-empty) default version instead. 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") introduced that generic version, and I suspect the arm version was left out by mistake, but it's not clear from that patch.
That was because PCI_HOST_ITE8152 needed something different from the "do nothing" default (setting the PCI latency timer to default to 64 as the new generic code did.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel