Re: [PATCH] watchdog: bcm63xx_wdt: fix fallthrough warning
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-10-27 17:40:47
Also in:
linux-watchdog
On 10/27/21 10:31 AM, Guenter Roeck wrote:
On Wed, Oct 27, 2021 at 02:31:35PM +0200, Rafał Miłecki wrote:quoted
From: Rafał Miłecki <rafal@milecki.pl> This fixes: drivers/watchdog/bcm63xx_wdt.c: In function 'bcm63xx_wdt_ioctl': drivers/watchdog/bcm63xx_wdt.c:208:17: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Rafał Miłecki <rafal@milecki.pl>[reluctantly] Reviewed-by: Guenter Roeck <linux@roeck-us.net> ... because the driver should really be converted to use the watchdog subsystem, by someone with the necessary hardware to test it.
The driver should ideally be removed and we should use bcm7038_wdt.c moving forward. Rafal, is this something you can try on 4908? We would have to pay attention to arch/mips/bcm63xx/dev_wdt.c and introduce a MODULE_DEVICE_TABLE() and platform_device_id so we can key off any BCM63xx-specific behavior. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel