Re: [PATCH] watchdog: bcm63xx_wdt: fix fallthrough warning
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-10-27 17:32:49
Also in:
linux-watchdog
On Wed, Oct 27, 2021 at 02:31:35PM +0200, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@milecki.pl> This fixes: drivers/watchdog/bcm63xx_wdt.c: In function 'bcm63xx_wdt_ioctl': drivers/watchdog/bcm63xx_wdt.c:208:17: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
[reluctantly] Reviewed-by: Guenter Roeck <linux@roeck-us.net> ... because the driver should really be converted to use the watchdog subsystem, by someone with the necessary hardware to test it. Guenter
quoted hunk ↗ jump to hunk
--- drivers/watchdog/bcm63xx_wdt.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/watchdog/bcm63xx_wdt.c b/drivers/watchdog/bcm63xx_wdt.c index 7cdb25363ea0..56cc262571a5 100644 --- a/drivers/watchdog/bcm63xx_wdt.c +++ b/drivers/watchdog/bcm63xx_wdt.c@@ -207,6 +207,8 @@ static long bcm63xx_wdt_ioctl(struct file *file, unsigned int cmd, bcm63xx_wdt_pet(); + fallthrough; + case WDIOC_GETTIMEOUT: return put_user(wdt_time, p);-- 2.31.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel