Re: [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property

On Sat, 23 Oct 2021 23:48:53 +0200, Alexander Stein wrote:

Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
do not match any of the regexes: 'pinctrl-[0-9]+'"

Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation")
Signed-off-by: Alexander Stein <redacted>
---
I am aware that adding required properties to bindings is frowned upon. But in
this case it seems acceptable for the following reasons:
* AVDD-supply was used from the very first driver commit
* All DT (g12 and gxl) using t9015 controller provide AVDD-supply
  already
But I'm ok to not add it to required properties as well. The driver uses
it nevertheless though.

 Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
 1 file changed, 5 insertions(+)

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.example.dt.yaml: audio-controller@32000: 'AVDD-supply' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1545246

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel