From: Alexander Stein <hidden> Date: 2021-10-23 21:49:22
Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
do not match any of the regexes: 'pinctrl-[0-9]+'"
Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation")
Signed-off-by: Alexander Stein <redacted>
---
I am aware that adding required properties to bindings is frowned upon. But in
this case it seems acceptable for the following reasons:
* AVDD-supply was used from the very first driver commit
* All DT (g12 and gxl) using t9015 controller provide AVDD-supply
already
But I'm ok to not add it to required properties as well. The driver uses
it nevertheless though.
Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
1 file changed, 5 insertions(+)
From: Alexander Stein <hidden> Date: 2021-10-23 21:49:23
Starting with commit 94274f20f6bf ("dt-bindings: opp: Convert to DT
schema") the opp node name has a mandatory pattern. This change
fixes the dtbs_check warning:
gpu-opp-table: $nodename:0: 'gpu-opp-table' does not match
'^opp-table(-[a-z0-9]+)?$'
Put the 'gpu' part at the end to match the pattern.
Fixes: 916a0edc43f0 ("arm64: dts: amlogic: meson-g12: add the Mali OPP table and use DVFS")
Signed-off-by: Alexander Stein <redacted>
---
Same as with patch 2/4 about the 'Fixes' tag: At the time when
gpu-opp-table was added there was no schema present. So there was no bug at
the time of writing. I'm ok either way.
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Alexander Stein <hidden> Date: 2021-10-23 21:49:25
This node is currently at /soc/thermal-zones, but the later introduced
bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
for thermal zones") put this at /thermal-zones.
Fix dtb_check warning by moving the thermal-zones node to /
Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
Signed-off-by: Alexander Stein <redacted>
---
I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
thermal-zones were added there was no schema present. So there was no bug at
the time of writing. I'm ok either way.
.../boot/dts/amlogic/meson-g12-common.dtsi | 110 +++++++++---------
1 file changed, 55 insertions(+), 55 deletions(-)
From: Rob Herring <robh@kernel.org> Date: 2021-10-24 14:27:33
On Sat, 23 Oct 2021 23:48:53 +0200, Alexander Stein wrote:
Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
do not match any of the regexes: 'pinctrl-[0-9]+'"
Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation")
Signed-off-by: Alexander Stein <redacted>
---
I am aware that adding required properties to bindings is frowned upon. But in
this case it seems acceptable for the following reasons:
* AVDD-supply was used from the very first driver commit
* All DT (g12 and gxl) using t9015 controller provide AVDD-supply
already
But I'm ok to not add it to required properties as well. The driver uses
it nevertheless though.
Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
1 file changed, 5 insertions(+)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.example.dt.yaml: audio-controller@32000: 'AVDD-supply' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1545246
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Neil Armstrong <hidden> Date: 2021-10-25 08:19:59
On 23/10/2021 23:48, Alexander Stein wrote:
quoted hunk
Starting with commit 94274f20f6bf ("dt-bindings: opp: Convert to DT
schema") the opp node name has a mandatory pattern. This change
fixes the dtbs_check warning:
gpu-opp-table: $nodename:0: 'gpu-opp-table' does not match
'^opp-table(-[a-z0-9]+)?$'
Put the 'gpu' part at the end to match the pattern.
Fixes: 916a0edc43f0 ("arm64: dts: amlogic: meson-g12: add the Mali OPP table and use DVFS")
Signed-off-by: Alexander Stein <redacted>
---
Same as with patch 2/4 about the 'Fixes' tag: At the time when
gpu-opp-table was added there was no schema present. So there was no bug at
the time of writing. I'm ok either way.
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Mark Brown <broonie@kernel.org> Date: 2021-10-25 09:44:09
On Sat, Oct 23, 2021 at 11:48:53PM +0200, Alexander Stein wrote:
Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
do not match any of the regexes: 'pinctrl-[0-9]+'"
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
On Sat 23 Oct 2021 at 23:48, Alexander Stein [off-list ref] wrote:
Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
do not match any of the regexes: 'pinctrl-[0-9]+'"
Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation")
Signed-off-by: Alexander Stein <redacted>
Hey Alexander,
First, thanks for picking this up.
I think Rob's automated reply is because you forgot to update the
example (if the property is required, it should be there)
Also, I believe this change could have been sent separately, to Marc
(instead of Cc) and with the "ASoC" prefix.
With this changed
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
quoted hunk
---
I am aware that adding required properties to bindings is frowned upon. But in
this case it seems acceptable for the following reasons:
* AVDD-supply was used from the very first driver commit
* All DT (g12 and gxl) using t9015 controller provide AVDD-supply
already
But I'm ok to not add it to required properties as well. The driver uses
it nevertheless though.
Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
1 file changed, 5 insertions(+)
From: Neil Armstrong <hidden> Date: 2021-10-26 07:27:48
Hi,
On 23/10/2021 23:48, Alexander Stein wrote:
This node is currently at /soc/thermal-zones, but the later introduced
bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
for thermal zones") put this at /thermal-zones.
Fix dtb_check warning by moving the thermal-zones node to /
Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
Signed-off-by: Alexander Stein <redacted>
---
I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
thermal-zones were added there was no schema present. So there was no bug at
the time of writing. I'm ok either way.
I'm also unsure about it, either you list all commits that must be present for the fix to be applied,
or remove it since it's not a bug.
Neil
From: Alexander Stein <hidden> Date: 2021-10-26 16:21:55
Hello,
Am Dienstag, 26. Oktober 2021, 09:27:42 CEST schrieb Neil Armstrong:
On 23/10/2021 23:48, Alexander Stein wrote:
quoted
This node is currently at /soc/thermal-zones, but the later introduced
bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
for thermal zones") put this at /thermal-zones.
Fix dtb_check warning by moving the thermal-zones node to /
Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
Signed-off-by: Alexander Stein <redacted>
---
I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
thermal-zones were added there was no schema present. So there was no bug
at the time of writing. I'm ok either way.
I'm also unsure about it, either you list all commits that must be present
for the fix to be applied, or remove it since it's not a bug.
Alright, I'll remove the Fixes tag then and send a v2 with your Reviewed-By
for patches 3 & 4.
Best regards,
Alexander
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Alexander Stein <hidden> Date: 2021-10-26 16:31:01
Hello Jerome,
Am Montag, 25. Oktober 2021, 17:53:04 CEST schrieb Jerome Brunet:
On Sat 23 Oct 2021 at 23:48, Alexander Stein [off-list ref]
wrote:
quoted
Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
do not match any of the regexes: 'pinctrl-[0-9]+'"
Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding
documentation") Signed-off-by: Alexander Stein
[off-list ref]
Hey Alexander,
First, thanks for picking this up.
I think Rob's automated reply is because you forgot to update the
example (if the property is required, it should be there)
Thanks for pointing that out, I noticed too that examples are validated as
well, nice feature.
Also, I believe this change could have been sent separately, to Marc
(instead of Cc) and with the "ASoC" prefix.
With this changed
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Yeah, I'll split the set during v2. Thanks for the review.
Best regards,
Alexander
quoted
---
I am aware that adding required properties to bindings is frowned upon.
But in this case it seems acceptable for the following reasons:
* AVDD-supply was used from the very first driver commit
* All DT (g12 and gxl) using t9015 controller provide AVDD-supply
already
But I'm ok to not add it to required properties as well. The driver uses
it nevertheless though.
Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
1 file changed, 5 insertions(+)