Dear arm maintainers,
The script ./scripts/checkkconfigsymbols.py warns on invalid references to
Kconfig symbols (often: minor typos, name confusions or outdated references).
This is a patch series addressing the issues reported by
./scripts/checkkconfigsymbols.py in the ./arch/arm{64}/ directories, quickly
filtered down with:
./scripts/checkkconfigsymbols.py | grep "arch/arm" -B 1 -A 2
without considering kernel configs, i.e., after removing arch/arm{64}/configs
in the working tree. It addresses some issues I considered to be "true positives";
so, issues that should be addressed and cleaned up.
The patches on updating the comments might arguably be considered of lower value
by itself, but as the other patches show, checkkconfigsymbols does detect some
relevant issues in the kernel tree otherwise being unnoticed.
So, it might be worth to clean up the kernel tree to have checkkconfigsymbols
produce a rather short list of issues and then continuously follow and check
what checkkconfigsymbols reports.
Some work from checkkconfigsymbols on arch/arm/ is deferred; the other remaining
issues that checkkconfigsymbols reports are (as far as I understand it now)
"false positives", i.e., the tool misinterprets the actual content) or
"intentional", e.g., they refer to historic configs for the purpose of
documentation (e.g., in changelogs) or are in various kernel configs that are
not continuously updated to match the current set of kernel configs. You can
see below a grouped list of remaining reports.
Each patch in this series can be discussed and applied individually if needed.
They are sent in one patch series, as they all orginate from the investigation
guided by the same tool and hence share similar topics and resolutions.
Please pick this series of minor clean-up patches on ./arch/arm{64}/.
It applies cleanly on next-20211027.
Best regards,
Lukas
Remaining reports from ./scripts/checkkconfigsymbols.py pointing to files in
./arch/arm{64}/ (excluding configs), grouped by the rationale why it is not
addressed in this patch series:
- Reference in historic comment:
ARM_NR_BANKS
Referencing files: arch/arm/mach-exynos/exynos.c
CPU
Referencing files: arch/arm/lib/backtrace.S, arch/arm/lib/csumpartialcopyuser.S,
arch/arm/mach-rpc/ecard-loader.S, arch/arm/mach-rpc/io-acorn.S, arch/arm/nwfpe/fpmodule.h
CPU_ARM92{0,2,5,6}_CPU_IDLE
Referencing files: arch/arm/mm/proc-arm92{0,2,5,6}.S
KVM_INDIRECT_VECTORS
Referencing files: arch/arm64/kvm/hyp/nvhe/host.S
- Use of CONFIG_* environment variable beyond the definition in Kconfig scripts
AS_DMB_ISHLD
Referencing files: arch/arm64/include/asm/vdso/compat_barrier.h, arch/arm64/kernel/vdso32/Makefile
CC_HAS_K_CONSTRAINT
Referencing files: arch/arm64/Makefile, arch/arm64/include/asm/atomic_ll_sc.h
SHELL
Ignore CONFIG_SHELL. Default variable in Kbuild build system.
- Parsing Mistake (Incomplete parsing heuristics) by checkkconfigsymbols.py:
ASC1, ASC2, SBC, UART
Referencing files: arch/arm/Kconfig.debug
- Future work to send clean-up patches:
IRDA{_MODULE}
Referencing files: arch/arm/mach-pxa/balloon3.c, arch/arm/mach-pxa/palm27x.c,
arch/arm/mach-pxa/palm27x.h, arch/arm/mach-pxa/palmtc.c, include/linux/atalk.h,
include/linux/netdevice.h
PXA_FICP{_MODULE}
Referencing files: arch/arm/mach-pxa/spitz.c
DEBUG_LL_SER3
Referencing files: arch/arm/boot/compressed/head.S
already discussed in 2014: https://lore.kernel.org/all/1400055127.31197.1.camel@x220/
Lukas Bulwahn (13):
arm: debug: remove obsolete debug code for DEBUG_ZTE_ZX
arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5}
arm: Kconfig.debug: drop reference to removed ARCH_MSM
arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152
arm: davinci: remove reference to obsolete BLK_DEV_PALMCHIP_BK3710
arm: ixp4xx: remove dead configs CPU_IXP43X and CPU_IXP46X
arm: imx: remove dead left-over from i.MX{27,31,35} removal
arm: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART
arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT
arm: nomadik: drop selecting obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK
arm: npcm: drop selecting non-existing ARM_ERRATA_794072
arm: socfpga: always select PL310_ERRATA_753970
arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment
arch/arm/Kconfig.debug | 28 ++++++++++-------------
arch/arm/include/debug/imx-uart.h | 18 +++++++--------
arch/arm/include/debug/pl01x.S | 7 ------
arch/arm/kernel/bios32.c | 2 --
arch/arm/mach-davinci/board-dm644x-evm.c | 3 +--
arch/arm/mach-davinci/board-dm646x-evm.c | 3 +--
arch/arm/mach-davinci/board-neuros-osd2.c | 3 +--
arch/arm/mach-imx/Kconfig | 12 ----------
arch/arm/mach-imx/Makefile | 2 --
arch/arm/mach-ixp4xx/Kconfig | 13 -----------
arch/arm/mach-milbeaut/Kconfig | 1 -
arch/arm/mach-nomadik/Kconfig | 1 -
arch/arm/mach-npcm/Kconfig | 1 -
arch/arm/mach-socfpga/Kconfig | 2 +-
arch/arm/mm/pgd.c | 2 +-
15 files changed, 26 insertions(+), 72 deletions(-)
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for omap2 and
omap3/4/5 common uarts") adds address definitions of DEBUG_UART_PHYS for
OMAP2, OMAP3, OMAP4 and OMAP5 in ./arch/arm/Kconfig.debug.
These definitions depend on DEBUG_OMAP{2,3,4,5}UART{1,2}; however, only
DEBUG_OMAP2UART{1,2} are defined in ./arch/arm/Kconfig.debug, and
DEBUG_OMAP{3,4,5}UART{1,2} are not defined. Hence, the script
./scripts/checkkconfigsymbols.py warns here on non-existing symbols.
Simply reuse the config DEBUG_OMAP2UART{1,2}; there is no need to define
separate config symbols for OMAP{3,4,5}. So, just delete the dead
references to DEBUG_OMAP{3,4,5}UART{1,2}.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/Kconfig.debug | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
Commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM architecture
code") removes the definition of the config ARCH_MSM. Since then, the
reference to ARCH_MSM in the dependencies of UNCOMPRESS_INCLUDE in
Kconfig.debug is dead.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
ARCH_MSM
Referencing files: arch/arm/Kconfig.debug
Drop the dependency on this removed config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Commit 73d04ca5f4ac ("ARM: ixp4xx: Delete Intel reference design
boardfiles") removes the definition of the configs MACH_IXDP465 and
MACH_KIXRP435, but misses to remove the configs CPU_IXP43X and CPU_IXP46X
that depend on those removed configs, and hence are dead now.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
MACH_IXDP465
Referencing files: arch/arm/mach-ixp4xx/Kconfig
MACH_KIXRP435
Referencing files: arch/arm/mach-ixp4xx/Kconfig
Remove the dead configs CPU_IXP43X and CPU_IXP46X.
A further quick grep for the name of those two symbols did not show any
use of the two config symbols; so, there are no further clean-up activities
beyond this config removal needed.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-ixp4xx/Kconfig | 13 -------------
1 file changed, 13 deletions(-)
@@ -39,19 +39,6 @@ config ARCH_PRPMC1100PrPCM1100ProcessorMezanineModule.Formoreinformationonthisplatform,see<file:Documentation/arm/ixp4xx.rst>.-#-# Certain registers and IRQs are only enabled if supporting IXP465 CPUs-#-configCPU_IXP46X-bool-depends onMACH_IXDP465-defaulty--configCPU_IXP43X-bool-depends onMACH_KIXRP435-defaulty-comment"IXP4xx Options"configIXP4XX_PCI_LEGACY
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
The commits:
commit 879c0e5e0ac7 ("ARM: imx: Remove i.MX27 board files")
commit c93197b0041d ("ARM: imx: Remove i.MX31 board files")
commit e1324ece2af4 ("ARM: imx: Remove i.MX35 board files")
remove the config MACH_MX27_3DS, MACH_MX31_3DS and MACH_MX35_3DS.
Commit a542fc18168c ("ARM: imx31: Remove remaining i.MX31 board code")
further removes arch/arm/mach-imx/3ds_debugboard.{c,h}. So, only some
dead left-over in Kconfig and Makefile remains.
Remove this remaining left-over.
This issue was identified with ./scripts/checkkconfigsymbols.py,
which warns on references to the non-existing configs
MACH_MX{27,31,35}_3DS in ./arch/arm/mach-imx/Kconfig.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-imx/Kconfig | 12 ------------
arch/arm/mach-imx/Makefile | 2 --
2 files changed, 14 deletions(-)
Since commit 4b563a066611 ("ARM: imx: Remove imx21 support"), the config
DEBUG_IMX21_IMX27_UART is really only debug support for IMX27.
So, rename this option to DEBUG_IMX27_UART and adjust dependencies in
Kconfig and rename the definitions to IMX27 as further clean-up.
This issue was discovered with ./scripts/checkkconfigsymbols.py, which
reported that DEBUG_IMX21_IMX27_UART depends on the non-existing config
SOC_IMX21.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/Kconfig.debug | 14 +++++++-------
arch/arm/include/debug/imx-uart.h | 18 +++++++++---------
2 files changed, 16 insertions(+), 16 deletions(-)
The patch series "Add basic support for Socionext Milbeaut M10V SoC" (see
Link) introduced the config ARCH_MILBEAUT_M10V "Milbeaut SC2000/M10V
platform" in ./arch/arm/mach-milbeaut/ and intended to introduce timer,
clock, pinctrl and serial controller drivers.
However, during patch submission in March 2019, the introduction of the
milbeaut pinctrl driver was dropped from v2 to v3 of the patch series.
Since then, there was no further patch series to add this pinctrl driver
later on.
Hence, selecting PINCTRL_MILBEAUT in config is simply dangling and
referring to a non-existing config symbols.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
PINCTRL_MILBEAUT
Referencing files: arch/arm/mach-milbeaut/Kconfig
Remove this select of the non-existing PINCTRL_MILBEAUT for now.
Link: https://lore.kernel.org/linux-arm-kernel/1551243056-10521-1-git-send-email-sugaya.taichi@socionext.com/
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-milbeaut/Kconfig | 1 -
1 file changed, 1 deletion(-)
Commit 85b6fcadcf66 ("clocksource/drivers/ux500: Drop Ux500 custom
SCHED_CLOCK") removes a sched_clock workaround and its corresponding
config CLKSRC_NOMADIK_MTU_SCHED_CLOCK. Since then, selecting
CLKSRC_NOMADIK_MTU_SCHED_CLOCK in ./arch/arm/mach-nomadik/Kconfig has no
effect and ./scripts/checkkconfigsymbols.py warns:
CLKSRC_NOMADIK_MTU_SCHED_CLOCK
Referencing files: arch/arm/mach-nomadik/Kconfig
Simply drop selecting the obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-nomadik/Kconfig | 1 -
1 file changed, 1 deletion(-)
There is no and never was a Kconfig for ARM_ERRATA_794072 in the kernel
tree. So, there is no need to select ARM_ERRATA_794072 in
./arch/arm/mach-npcm/Kconfig.
Simply drop selecting the non-existing ARM_ERRATA_794072.
This issue was discovered with ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-npcm/Kconfig | 1 -
1 file changed, 1 deletion(-)
Commit fbc125afdc50 ("ARM: socfpga: Turn on ARM errata for L2 cache") adds
some selects in ./arch/arm/mach-socfpga/Kconfig, with one select being
conditionally selected on the non-existing Kconfig symbol PL310.
Hence, ./scripts/checkkconfigsymbols.py warns:
PL310
Referencing files: arch/arm/mach-socfpga/Kconfig
Assuming that this errata should actually be selected for
ARCH_INTEL_SOCFPGA, simply select this config unconditionally.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-socfpga/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
good practice to annotate the endif's with a comment to indicate the
corresponding ifdef condition.
One comment annotation refers to CONFIG_LPAE, whereas the config is
actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
tolerable for all human readers.
However, the script ./scripts/checkkconfigsymbols.py, which checks the
kernel tree for references to non-existing Kconfig symbols, identifies and
reports that the reference to CONFIG_LPAE is invalid.
The script ./scripts/checkkconfigsymbols.py has been quite useful to
identify a number of bugs with Kconfig symbols and deserves to be executed
and checked regularly.
So, repair the comment to reduce the reports from this script and simplify
to use this script, as new issues are easier to spot when the list of
reports is shorter.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mm/pgd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit 89d4f98ae90d ("ARM: remove zte zx platform") removes the config
DEBUG_ZTE_ZX. Hence, since then, the "ifdef CONFIG_DEBUG_ZTE_ZX" in
./arch/arm/include/debug/pl01x.S is dead code.
Fortunately, ./scripts/checkkconfigsymbols.py detects this and warns:
DEBUG_ZTE_ZX
Referencing files: arch/arm/include/debug/pl01x.S
So, remove the obsolete ifdef CONFIG_DEBUG_ZTE_ZX.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I see another copy of these constants in drivers/tty/serial/amba-pl011.c,
which we should probably clean up as well.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for omap2 and
omap3/4/5 common uarts") adds address definitions of DEBUG_UART_PHYS for
OMAP2, OMAP3, OMAP4 and OMAP5 in ./arch/arm/Kconfig.debug.
These definitions depend on DEBUG_OMAP{2,3,4,5}UART{1,2}; however, only
DEBUG_OMAP2UART{1,2} are defined in ./arch/arm/Kconfig.debug, and
DEBUG_OMAP{3,4,5}UART{1,2} are not defined. Hence, the script
./scripts/checkkconfigsymbols.py warns here on non-existing symbols.
Simply reuse the config DEBUG_OMAP2UART{1,2}; there is no need to define
separate config symbols for OMAP{3,4,5}. So, just delete the dead
references to DEBUG_OMAP{3,4,5}UART{1,2}.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted hunk
Commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM architecture
code") removes the definition of the config ARCH_MSM. Since then, the
reference to ARCH_MSM in the dependencies of UNCOMPRESS_INCLUDE in
Kconfig.debug is dead.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
ARCH_MSM
Referencing files: arch/arm/Kconfig.debug
Drop the dependency on this removed config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The PLAT_SAMSUNG reference is also misplaced here, I think you just want
ARCH_S3C24XX instead, since the other samsung ones already require
ARCH_MULTIPLATFORM.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver")
removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef
in ./arch/arm/kernel/bios32.c.
Hence, ./scripts/checkkconfigsymbols.py warns:
PCI_HOST_ITE8152
Referencing files: arch/arm/kernel/bios32.c
Remove this obsolete ifndef.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I wonder if we should just remove this function and use the
(non-empty) default version instead.
96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core")
introduced that generic version, and I suspect the arm version
was left out by mistake, but it's not clear from that patch.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit b7fb14d3ac63 ("ide: remove the legacy ide driver") removes the
definition of the config BLK_DEV_PALMCHIP_BK3710.
So, remove the obsolete references in the mach-davinci architecture.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit 73d04ca5f4ac ("ARM: ixp4xx: Delete Intel reference design
boardfiles") removes the definition of the configs MACH_IXDP465 and
MACH_KIXRP435, but misses to remove the configs CPU_IXP43X and CPU_IXP46X
that depend on those removed configs, and hence are dead now.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
MACH_IXDP465
Referencing files: arch/arm/mach-ixp4xx/Kconfig
MACH_KIXRP435
Referencing files: arch/arm/mach-ixp4xx/Kconfig
Remove the dead configs CPU_IXP43X and CPU_IXP46X.
A further quick grep for the name of those two symbols did not show any
use of the two config symbols; so, there are no further clean-up activities
beyond this config removal needed.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
The commits:
commit 879c0e5e0ac7 ("ARM: imx: Remove i.MX27 board files")
commit c93197b0041d ("ARM: imx: Remove i.MX31 board files")
commit e1324ece2af4 ("ARM: imx: Remove i.MX35 board files")
remove the config MACH_MX27_3DS, MACH_MX31_3DS and MACH_MX35_3DS.
Commit a542fc18168c ("ARM: imx31: Remove remaining i.MX31 board code")
further removes arch/arm/mach-imx/3ds_debugboard.{c,h}. So, only some
dead left-over in Kconfig and Makefile remains.
Remove this remaining left-over.
This issue was identified with ./scripts/checkkconfigsymbols.py,
which warns on references to the non-existing configs
MACH_MX{27,31,35}_3DS in ./arch/arm/mach-imx/Kconfig.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Since commit 4b563a066611 ("ARM: imx: Remove imx21 support"), the config
DEBUG_IMX21_IMX27_UART is really only debug support for IMX27.
So, rename this option to DEBUG_IMX27_UART and adjust dependencies in
Kconfig and rename the definitions to IMX27 as further clean-up.
This issue was discovered with ./scripts/checkkconfigsymbols.py, which
reported that DEBUG_IMX21_IMX27_UART depends on the non-existing config
SOC_IMX21.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit 85b6fcadcf66 ("clocksource/drivers/ux500: Drop Ux500 custom
SCHED_CLOCK") removes a sched_clock workaround and its corresponding
config CLKSRC_NOMADIK_MTU_SCHED_CLOCK. Since then, selecting
CLKSRC_NOMADIK_MTU_SCHED_CLOCK in ./arch/arm/mach-nomadik/Kconfig has no
effect and ./scripts/checkkconfigsymbols.py warns:
CLKSRC_NOMADIK_MTU_SCHED_CLOCK
Referencing files: arch/arm/mach-nomadik/Kconfig
Simply drop selecting the obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
The patch series "Add basic support for Socionext Milbeaut M10V SoC" (see
Link) introduced the config ARCH_MILBEAUT_M10V "Milbeaut SC2000/M10V
platform" in ./arch/arm/mach-milbeaut/ and intended to introduce timer,
clock, pinctrl and serial controller drivers.
However, during patch submission in March 2019, the introduction of the
milbeaut pinctrl driver was dropped from v2 to v3 of the patch series.
Since then, there was no further patch series to add this pinctrl driver
later on.
Hence, selecting PINCTRL_MILBEAUT in config is simply dangling and
referring to a non-existing config symbols.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
PINCTRL_MILBEAUT
Referencing files: arch/arm/mach-milbeaut/Kconfig
Remove this select of the non-existing PINCTRL_MILBEAUT for now.
Link: https://lore.kernel.org/linux-arm-kernel/1551243056-10521-1-git-send-email-sugaya.taichi@socionext.com/
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
I would take that as an indication that there is no interest in supporting this
platform upstream any more, the version we merged probably never worked
without the rest of the drivers.
I've added the original authors of the other drivers to Cc. Should we remove
all of this?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
There is no and never was a Kconfig for ARM_ERRATA_794072 in the kernel
tree. So, there is no need to select ARM_ERRATA_794072 in
./arch/arm/mach-npcm/Kconfig.
Simply drop selecting the non-existing ARM_ERRATA_794072.
This issue was discovered with ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Could this be a typo? Maybe we need to enable a different errata workaround
here, or maybe that code is actually needed and has to get sent.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit fbc125afdc50 ("ARM: socfpga: Turn on ARM errata for L2 cache") adds
some selects in ./arch/arm/mach-socfpga/Kconfig, with one select being
conditionally selected on the non-existing Kconfig symbol PL310.
Hence, ./scripts/checkkconfigsymbols.py warns:
PL310
Referencing files: arch/arm/mach-socfpga/Kconfig
Assuming that this errata should actually be selected for
ARCH_INTEL_SOCFPGA, simply select this config unconditionally.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
I think it has to be
select PL310_ERRATA_753970 if CACHE_L2X0
otherwise you get a Kconfig warning when building a kernel without the
L2X0 driver.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
good practice to annotate the endif's with a comment to indicate the
corresponding ifdef condition.
One comment annotation refers to CONFIG_LPAE, whereas the config is
actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
tolerable for all human readers.
However, the script ./scripts/checkkconfigsymbols.py, which checks the
kernel tree for references to non-existing Kconfig symbols, identifies and
reports that the reference to CONFIG_LPAE is invalid.
The script ./scripts/checkkconfigsymbols.py has been quite useful to
identify a number of bugs with Kconfig symbols and deserves to be executed
and checked regularly.
So, repair the comment to reduce the reports from this script and simplify
to use this script, as new issues are easier to spot when the list of
reports is shorter.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
From: "Russell King (Oracle)" <linux@armlinux.org.uk> Date: 2021-10-28 15:36:09
On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver")
removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef
in ./arch/arm/kernel/bios32.c.
Hence, ./scripts/checkkconfigsymbols.py warns:
PCI_HOST_ITE8152
Referencing files: arch/arm/kernel/bios32.c
Remove this obsolete ifndef.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I wonder if we should just remove this function and use the
(non-empty) default version instead.
96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core")
introduced that generic version, and I suspect the arm version
was left out by mistake, but it's not clear from that patch.
That was because PCI_HOST_ITE8152 needed something different from the
"do nothing" default (setting the PCI latency timer to default to 64
as the new generic code did.)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:38 PM Arnd Bergmann [off-list ref] wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
Commit 89d4f98ae90d ("ARM: remove zte zx platform") removes the config
DEBUG_ZTE_ZX. Hence, since then, the "ifdef CONFIG_DEBUG_ZTE_ZX" in
./arch/arm/include/debug/pl01x.S is dead code.
Fortunately, ./scripts/checkkconfigsymbols.py detects this and warns:
DEBUG_ZTE_ZX
Referencing files: arch/arm/include/debug/pl01x.S
So, remove the obsolete ifdef CONFIG_DEBUG_ZTE_ZX.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I see another copy of these constants in drivers/tty/serial/amba-pl011.c,
which we should probably clean up as well.
Arnd, did you have something like this---see below---for serial
amba-pl011 in mind?
Then, I would adjust the patch to remove all the zte_zx serial
left-over in one commit.
Lukas
@@ -90,14 +90,8 @@ enum amba_vendor {AMBA_VENDOR_ST=0x80,AMBA_VENDOR_QCOM=0x51,AMBA_VENDOR_LSI=0xb6,-AMBA_VENDOR_LINUX=0xfe,/* This value is not official */};-/* This is used to generate pseudo-ID for AMBA device */-#define AMBA_LINUX_ID(conf, rev, part) \-(((conf)&0xff)<<24|((rev)&0xf)<<20|\-AMBA_VENDOR_LINUX<<12|((part)&0xfff))-externstructbus_typeamba_bustype;#define to_amba_device(d) container_of(d, struct amba_device, dev)
On Thu, Oct 28, 2021 at 5:35 PM Russell King (Oracle)
[off-list ref] wrote:
On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote:
quoted
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver")
removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef
in ./arch/arm/kernel/bios32.c.
Hence, ./scripts/checkkconfigsymbols.py warns:
PCI_HOST_ITE8152
Referencing files: arch/arm/kernel/bios32.c
Remove this obsolete ifndef.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I wonder if we should just remove this function and use the
(non-empty) default version instead.
96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core")
introduced that generic version, and I suspect the arm version
was left out by mistake, but it's not clear from that patch.
That was because PCI_HOST_ITE8152 needed something different from the
"do nothing" default (setting the PCI latency timer to default to 64
as the new generic code did.)
So, can we just drop the empty pcibios_set_master() function in
bios32.c and the pci handling will now (after the removal of
PCI_HOST_ITE8152) just do The Right Thing(TM)?
If you can confirm that, I will send an updated patch here.
Thanks,
Lukas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fri, Oct 29, 2021 at 7:34 AM Lukas Bulwahn [off-list ref] wrote:
On Thu, Oct 28, 2021 at 4:38 PM Arnd Bergmann [off-list ref] wrote:
quoted
Arnd, did you have something like this---see below---for serial
amba-pl011 in mind?
Then, I would adjust the patch to remove all the zte_zx serial
left-over in one commit.
From: Joel Stanley <joel@jms.id.au> Date: 2021-10-29 06:36:40
On Thu, 28 Oct 2021 at 14:57, Arnd Bergmann [off-list ref] wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
There is no and never was a Kconfig for ARM_ERRATA_794072 in the kernel
tree. So, there is no need to select ARM_ERRATA_794072 in
./arch/arm/mach-npcm/Kconfig.
Simply drop selecting the non-existing ARM_ERRATA_794072.
This issue was discovered with ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Could this be a typo? Maybe we need to enable a different errata workaround
here, or maybe that code is actually needed and has to get sent.
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
The patch series "Add basic support for Socionext Milbeaut M10V SoC" (see
Link) introduced the config ARCH_MILBEAUT_M10V "Milbeaut SC2000/M10V
platform" in ./arch/arm/mach-milbeaut/ and intended to introduce timer,
clock, pinctrl and serial controller drivers.
However, during patch submission in March 2019, the introduction of the
milbeaut pinctrl driver was dropped from v2 to v3 of the patch series.
Since then, there was no further patch series to add this pinctrl driver
later on.
Hence, selecting PINCTRL_MILBEAUT in config is simply dangling and
referring to a non-existing config symbols.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
PINCTRL_MILBEAUT
Referencing files: arch/arm/mach-milbeaut/Kconfig
Remove this select of the non-existing PINCTRL_MILBEAUT for now.
Link: https://lore.kernel.org/linux-arm-kernel/1551243056-10521-1-git-send-email-sugaya.taichi@socionext.com/
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
I would take that as an indication that there is no interest in supporting this
platform upstream any more, the version we merged probably never worked
without the rest of the drivers.
I've added the original authors of the other drivers to Cc. Should we remove
all of this?
Arnd
It is okay to drop PINCTRL_MILBEAUT. I will add it again when working at the pinctrl
driver. But don`t remove the milbeaut platform. Actually we haven't been doing
maintenance recently, but we have plans to add drivers in the future.
Thanks,
Taichi Sugaya
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fri, Oct 29, 2021 at 8:36 AM Joel Stanley [off-list ref] wrote:
On Thu, 28 Oct 2021 at 14:57, Arnd Bergmann [off-list ref] wrote:
quoted
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
There is no and never was a Kconfig for ARM_ERRATA_794072 in the kernel
tree. So, there is no need to select ARM_ERRATA_794072 in
./arch/arm/mach-npcm/Kconfig.
Simply drop selecting the non-existing ARM_ERRATA_794072.
This issue was discovered with ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Could this be a typo? Maybe we need to enable a different errata workaround
here, or maybe that code is actually needed and has to get sent.
I will happily update the patch to select ARM_ERRATA_742230 instead of
the dead non-existing ARM_ERRATA_794072.
In contrast to the current patch that basically only cleans up "dead
config" and has no effective functional change, the new patch would
change the behaviour. I cannot test this patch (beyond some basic
compile test) on the hardware; so, we certainly need someone to have
that hardware, knows how to test it or confirm otherwise that we
should select the ARM_ERRATA_742230 fix for this hardware.
The current patch should be subsumed by the new patch; the submission
of the new patch is deferred until that person shows up. Let's see.
Lukas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:42 PM Arnd Bergmann [off-list ref] wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
Commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM architecture
code") removes the definition of the config ARCH_MSM. Since then, the
reference to ARCH_MSM in the dependencies of UNCOMPRESS_INCLUDE in
Kconfig.debug is dead.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
ARCH_MSM
Referencing files: arch/arm/Kconfig.debug
Drop the dependency on this removed config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The PLAT_SAMSUNG reference is also misplaced here, I think you just want
ARCH_S3C24XX instead, since the other samsung ones already require
ARCH_MULTIPLATFORM.
Agree. I can clean up (or better stated: optimize) the dependencies
further in such a way. But that config dependency optimization goes
beyond just removing dead symbols and deserves to be its own patch.
Patch will follow later this week.
Lukas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
I will happily update the patch to select ARM_ERRATA_742230 instead of
the dead non-existing ARM_ERRATA_794072.
In contrast to the current patch that basically only cleans up "dead
config" and has no effective functional change, the new patch would
change the behaviour. I cannot test this patch (beyond some basic
compile test) on the hardware; so, we certainly need someone to have
that hardware, knows how to test it or confirm otherwise that we
should select the ARM_ERRATA_742230 fix for this hardware.
The current patch should be subsumed by the new patch; the submission
of the new patch is deferred until that person shows up. Let's see.
I'd prefer to leave the broken Kconfig symbol in place as a reminder until it
gets fixed properly then.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Avi Fishman <avifishman70@gmail.com> Date: 2021-11-02 08:22:41
Hi,
At Nuvoton we implied this WA in the past, not because we encountered
a specific problem but since the errata says so and we saw this in
other patches like:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/1396298072-13254-2-git-send-email-nitin.garg@freescale.com/
But we didn't upstream the arch/arm/mm/proc-v7.S
From the errata document.
"794072 A short loop including a DMB instruction might cause a denial
of service on
another processor which executes a CP15 broadcast operation
Status
Affects:
Fault Type:
Fault Status: Cortex-A9 MPCore.
Programmer Category B
Present in: All r1, r2, r3 and r4 revisions Open
Description
A processor which continuously executes a short loop containing a DMB
instruction might prevent a CP15
operation broadcast by another processor making further progress,
causing a denial of service.
Configurations affected
This erratum affects all Cortex-A9 MPCore processors with two or more
processors.
Conditions
The erratum requires the following conditions:
- Two or more processors are working in SMP mode (ACTLR.SMP=1)
- One of the processors continuously executes a short loop containing
at least one DMB instruction.
- Another processor executes a CP15 maintenance operation that is
broadcast. This requires that this
processor has enabled the broadcasting of CP15 operations (ACTLR.FW=1)
For the erratum to occur, the short loop containing the DMB
instruction must meet all of the following additional
conditions:
- No more than 10 instructions other than the DMB are executed between each DMB
- No non-conditional Load or Store, or conditional Load or Store which
pass the condition code check, are
executed between each DMB
When all the conditions for the erratum are met, the short loop
creates a continuous stream of DMB instructions.
This might cause a denial of service, by preventing the processor
executing the short loop from executing the
received broadcast CP15 operation. As a result, the processor that
originally executed the broadcast CP15
operation is stalled until the execution of the loop is interrupted.
Note that because the process issuing the CP15 broadcast operation
cannot complete operation, it cannot enter
any debug-mode, and cannot take any interrupt. If the processor
executing the short loop also cannot be
interrupted, for example if it has disabled its interrupts, or if no
interrupts are routed to this processor, this
erratum might cause a system livelock.
Implications
The erratum might create performance issues, or in the worst case it
might cause a system livelock if the
processor executing the DMB is in an infinite loop that cannot be interrupted.
Workaround
This erratum can be worked round by setting bit[4] of the undocumented
Diagnostic Control Register to 1. This
register is encoded as CP15 c15 0 c0 1.
This bit can be written in Secure state only, with the following
Read/Modify/Write code sequence:
MRC p15,0,rt,c15,c0,1
ORR rt,rt,#0x10
MCR p15,0,rt,c15,c0,1
When it is set, this bit causes the DMB instruction to be decoded and
executed like a DSB.
Using this software workaround is not expected to have any impact on
the overall performance of the processor
on a typical code base.
Other workarounds are also available for this erratum, to either
prevent or interrupt the continuous stream of
DMB instructions that causes the deadlock. For example:
- Inserting a non-conditional Load or Store instruction in the loop
between each DMB
- Inserting additional instructions in the loop, such as NOPs, to
avoid the processor seeing back to back
DMB instructions.
- Making the processor executing the short loop take regular interrupts."
Avi
On Tue, Nov 2, 2021 at 9:31 AM Lukas Bulwahn [off-list ref] wrote:
On Fri, Oct 29, 2021 at 8:36 AM Joel Stanley [off-list ref] wrote:
quoted
On Thu, 28 Oct 2021 at 14:57, Arnd Bergmann [off-list ref] wrote:
quoted
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
There is no and never was a Kconfig for ARM_ERRATA_794072 in the kernel
tree. So, there is no need to select ARM_ERRATA_794072 in
./arch/arm/mach-npcm/Kconfig.
Simply drop selecting the non-existing ARM_ERRATA_794072.
This issue was discovered with ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Could this be a typo? Maybe we need to enable a different errata workaround
here, or maybe that code is actually needed and has to get sent.
I will happily update the patch to select ARM_ERRATA_742230 instead of
the dead non-existing ARM_ERRATA_794072.
In contrast to the current patch that basically only cleans up "dead
config" and has no effective functional change, the new patch would
change the behaviour. I cannot test this patch (beyond some basic
compile test) on the hardware; so, we certainly need someone to have
that hardware, knows how to test it or confirm otherwise that we
should select the ARM_ERRATA_742230 fix for this hardware.
The current patch should be subsumed by the new patch; the submission
of the new patch is deferred until that person shows up. Let's see.
Lukas
From: Avi Fishman <avifishman70@gmail.com> Date: 2021-11-02 08:33:48
On Tue, Nov 2, 2021 at 10:22 AM Avi Fishman [off-list ref] wrote:
Hi,
At Nuvoton we implied this WA in the past, not because we encountered
a specific problem but since the errata says so and we saw this in
other patches like:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/1396298072-13254-2-git-send-email-nitin.garg@freescale.com/
But we didn't upstream the arch/arm/mm/proc-v7.S
From the errata document.
"794072 A short loop including a DMB instruction might cause a denial
of service on
another processor which executes a CP15 broadcast operation
Status
Affects:
Fault Type:
Fault Status: Cortex-A9 MPCore.
Programmer Category B
Present in: All r1, r2, r3 and r4 revisions Open
Description
A processor which continuously executes a short loop containing a DMB
instruction might prevent a CP15
operation broadcast by another processor making further progress,
causing a denial of service.
Configurations affected
This erratum affects all Cortex-A9 MPCore processors with two or more
processors.
Conditions
The erratum requires the following conditions:
- Two or more processors are working in SMP mode (ACTLR.SMP=1)
- One of the processors continuously executes a short loop containing
at least one DMB instruction.
- Another processor executes a CP15 maintenance operation that is
broadcast. This requires that this
processor has enabled the broadcasting of CP15 operations (ACTLR.FW=1)
For the erratum to occur, the short loop containing the DMB
instruction must meet all of the following additional
conditions:
- No more than 10 instructions other than the DMB are executed between each DMB
- No non-conditional Load or Store, or conditional Load or Store which
pass the condition code check, are
executed between each DMB
When all the conditions for the erratum are met, the short loop
creates a continuous stream of DMB instructions.
This might cause a denial of service, by preventing the processor
executing the short loop from executing the
received broadcast CP15 operation. As a result, the processor that
originally executed the broadcast CP15
operation is stalled until the execution of the loop is interrupted.
Note that because the process issuing the CP15 broadcast operation
cannot complete operation, it cannot enter
any debug-mode, and cannot take any interrupt. If the processor
executing the short loop also cannot be
interrupted, for example if it has disabled its interrupts, or if no
interrupts are routed to this processor, this
erratum might cause a system livelock.
Implications
The erratum might create performance issues, or in the worst case it
might cause a system livelock if the
processor executing the DMB is in an infinite loop that cannot be interrupted.
Workaround
This erratum can be worked round by setting bit[4] of the undocumented
Diagnostic Control Register to 1. This
register is encoded as CP15 c15 0 c0 1.
This bit can be written in Secure state only, with the following
Read/Modify/Write code sequence:
MRC p15,0,rt,c15,c0,1
ORR rt,rt,#0x10
MCR p15,0,rt,c15,c0,1
When it is set, this bit causes the DMB instruction to be decoded and
executed like a DSB.
Using this software workaround is not expected to have any impact on
the overall performance of the processor
on a typical code base.
Other workarounds are also available for this erratum, to either
prevent or interrupt the continuous stream of
DMB instructions that causes the deadlock. For example:
- Inserting a non-conditional Load or Store instruction in the loop
between each DMB
- Inserting additional instructions in the loop, such as NOPs, to
avoid the processor seeing back to back
DMB instructions.
- Making the processor executing the short loop take regular interrupts."
Avi
On Tue, Nov 2, 2021 at 9:31 AM Lukas Bulwahn [off-list ref] wrote:
quoted
On Fri, Oct 29, 2021 at 8:36 AM Joel Stanley [off-list ref] wrote:
quoted
On Thu, 28 Oct 2021 at 14:57, Arnd Bergmann [off-list ref] wrote:
quoted
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn [off-list ref] wrote:
quoted
There is no and never was a Kconfig for ARM_ERRATA_794072 in the kernel
tree. So, there is no need to select ARM_ERRATA_794072 in
./arch/arm/mach-npcm/Kconfig.
Simply drop selecting the non-existing ARM_ERRATA_794072.
This issue was discovered with ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Could this be a typo? Maybe we need to enable a different errata workaround
here, or maybe that code is actually needed and has to get sent.
I will happily update the patch to select ARM_ERRATA_742230 instead of
the dead non-existing ARM_ERRATA_794072.
In contrast to the current patch that basically only cleans up "dead
config" and has no effective functional change, the new patch would
change the behaviour. I cannot test this patch (beyond some basic
compile test) on the hardware; so, we certainly need someone to have
that hardware, knows how to test it or confirm otherwise that we
should select the ARM_ERRATA_742230 fix for this hardware.
I will happily update the patch to select ARM_ERRATA_742230 instead of
the dead non-existing ARM_ERRATA_794072.
In contrast to the current patch that basically only cleans up "dead
config" and has no effective functional change, the new patch would
change the behaviour. I cannot test this patch (beyond some basic
compile test) on the hardware; so, we certainly need someone to have
that hardware, knows how to test it or confirm otherwise that we
should select the ARM_ERRATA_742230 fix for this hardware.
The current patch should be subsumed by the new patch; the submission
of the new patch is deferred until that person shows up. Let's see.
I'd prefer to leave the broken Kconfig symbol in place as a reminder until it
gets fixed properly then.
Agree, this patch here should not be integrated. I rather expect that
Avi or others at Nuvoton will provide a proper patch to act
appropriately for the ARM_ERRATA_794072, or after proper analysis can
determine that there is no change in the kernel required.
Lukas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn [off-list ref] wrote:
Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
good practice to annotate the endif's with a comment to indicate the
corresponding ifdef condition.
One comment annotation refers to CONFIG_LPAE, whereas the config is
actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
tolerable for all human readers.
However, the script ./scripts/checkkconfigsymbols.py, which checks the
kernel tree for references to non-existing Kconfig symbols, identifies and
reports that the reference to CONFIG_LPAE is invalid.
The script ./scripts/checkkconfigsymbols.py has been quite useful to
identify a number of bugs with Kconfig symbols and deserves to be executed
and checked regularly.
So, repair the comment to reduce the reports from this script and simplify
to use this script, as new issues are easier to spot when the list of
reports is shorter.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Linus Walleij <redacted>
Please put this patch into Russell's patch tracker!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn [off-list ref] wrote:
Commit 73d04ca5f4ac ("ARM: ixp4xx: Delete Intel reference design
boardfiles") removes the definition of the configs MACH_IXDP465 and
MACH_KIXRP435, but misses to remove the configs CPU_IXP43X and CPU_IXP46X
that depend on those removed configs, and hence are dead now.
Fortunately, ./scripts/checkkconfigsymbols.py warns:
MACH_IXDP465
Referencing files: arch/arm/mach-ixp4xx/Kconfig
MACH_KIXRP435
Referencing files: arch/arm/mach-ixp4xx/Kconfig
Remove the dead configs CPU_IXP43X and CPU_IXP46X.
A further quick grep for the name of those two symbols did not show any
use of the two config symbols; so, there are no further clean-up activities
beyond this config removal needed.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn [off-list ref] wrote:
Commit 85b6fcadcf66 ("clocksource/drivers/ux500: Drop Ux500 custom
SCHED_CLOCK") removes a sched_clock workaround and its corresponding
config CLKSRC_NOMADIK_MTU_SCHED_CLOCK. Since then, selecting
CLKSRC_NOMADIK_MTU_SCHED_CLOCK in ./arch/arm/mach-nomadik/Kconfig has no
effect and ./scripts/checkkconfigsymbols.py warns:
CLKSRC_NOMADIK_MTU_SCHED_CLOCK
Referencing files: arch/arm/mach-nomadik/Kconfig
Simply drop selecting the obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 04:19:32PM +0200, Lukas Bulwahn wrote:
The commits:
commit 879c0e5e0ac7 ("ARM: imx: Remove i.MX27 board files")
commit c93197b0041d ("ARM: imx: Remove i.MX31 board files")
commit e1324ece2af4 ("ARM: imx: Remove i.MX35 board files")
remove the config MACH_MX27_3DS, MACH_MX31_3DS and MACH_MX35_3DS.
Commit a542fc18168c ("ARM: imx31: Remove remaining i.MX31 board code")
further removes arch/arm/mach-imx/3ds_debugboard.{c,h}. So, only some
dead left-over in Kconfig and Makefile remains.
Remove this remaining left-over.
This issue was identified with ./scripts/checkkconfigsymbols.py,
which warns on references to the non-existing configs
MACH_MX{27,31,35}_3DS in ./arch/arm/mach-imx/Kconfig.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 04:19:33PM +0200, Lukas Bulwahn wrote:
Since commit 4b563a066611 ("ARM: imx: Remove imx21 support"), the config
DEBUG_IMX21_IMX27_UART is really only debug support for IMX27.
So, rename this option to DEBUG_IMX27_UART and adjust dependencies in
Kconfig and rename the definitions to IMX27 as further clean-up.
This issue was discovered with ./scripts/checkkconfigsymbols.py, which
reported that DEBUG_IMX21_IMX27_UART depends on the non-existing config
SOC_IMX21.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>