Thread (31 messages) 31 messages, 8 authors, 2021-11-03

Re: [PATCH 03/13] dt-bindings: imx: Add pinctrl binding doc for i.MXRT1050

From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-10-24 18:07:43
Also in: linux-clk, linux-devicetree, linux-gpio, linux-mmc, linux-serial, lkml

On Sun, Oct 24, 2021 at 5:40 PM Jesse Taube [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+/*
+ * The pin function ID is a tuple of
+ * <mux_reg conf_reg input_reg mux_mode input_val>
+ */
+
+#define MXRT1050_IOMUXC_GPIO_EMC_00_SEMC_DA00                          0x014 0x204 0x000 0x0 0x0
+#define MXRT1050_IOMUXC_GPIO_EMC_00_FLEXPWM4_PWM0_A                    0x014 0x204 0x494 0x1 0x0
+#define MXRT1050_IOMUXC_GPIO_EMC_00_LPSPI2_SCK                         0x014 0x204 0x500 0x2 0x1
+#define MXRT1050_IOMUXC_GPIO_EMC_00_XBAR_INOUT2                                0x014 0x204 0x60C 0x3 0x0
+#define MXRT1050_IOMUXC_GPIO_EMC_00_FLEXIO1_D00                                0x014 0x204 0x000 0x4 0x0
+#define MXRT1050_IOMUXC_GPIO_EMC_00_GPIO4_IO00                         0x014 0x204 0x000 0x5 0x0
The constants don't appear to be needed in this header at all, as the binding
looks completely generic with a tuple of five values, so  you could simply
open-code the numbers where they are used, no need to include these
in a driver.

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help