Thread (48 messages) 48 messages, 6 authors, 2021-10-28

RE: [PATCH v3 6/9] dt-bindings: imx6q-pcie: Add PHY phandles and name properties

From: Richard Zhu <hongxing.zhu@nxp.com>
Date: 2021-10-22 02:04:47
Also in: linux-devicetree, linux-phy, lkml

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Tuesday, October 19, 2021 3:18 AM
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de; tharvey@gateworks.com; kishon@ti.com;
vkoul@kernel.org; galak@kernel.crashing.org; shawnguo@kernel.org;
linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
kernel@pengutronix.de; dl-linux-imx [off-list ref]
Subject: Re: [PATCH v3 6/9] dt-bindings: imx6q-pcie: Add PHY phandles and
name properties

On Tue, Oct 12, 2021 at 04:41:15PM +0800, Richard Zhu wrote:
quoted
i.MX8MM PCIe has the PHY. Add a PHY phandle and name properties in the
binding document.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 2911e565b260..99d9863a69cd 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -128,6 +128,12 @@ properties:
     enum: [1, 2, 3, 4]
     default: 1

+  phys:
+    description: Phandle of the Generic PHY to the PCIe PHY.
maxItems: 1

And drop 'description'
[Richard Zhu] Hi Rob: 
Do you mean to remove all the description, and just like this?
  phys:
    maxItems: 1
Ok, got that, would be changed as this one in v4 series later.
Thanks.

Best Regards
Richard Zhu
quoted
+
+  phy-names:
+    const: pcie-phy
+
   reset-gpio:
     description: Should specify the GPIO for controlling the PCI bus
device
quoted
       reset signal. It's not polarity aware and defaults to
active-low reset
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help