Thread (17 messages) 17 messages, 4 authors, 2021-10-21

RE: [PATCH v7 1/5] ARM: dts: aspeed: Drop reg-io-width from LPC nodes

From: ChiaWei Wang <hidden>
Date: 2021-10-21 06:59:39
Also in: linux-aspeed, linux-devicetree, lkml, openbmc

quoted hunk ↗ jump to hunk
From: Joel Stanley <joel@jms.id.au>
Sent: Thursday, October 21, 2021 2:54 PM

On Thu, 21 Oct 2021 at 06:48, Joel Stanley [off-list ref] wrote:
quoted
On Thu, 21 Oct 2021 at 06:37, ChiaWei Wang
[off-list ref] wrote:
quoted
quoted
However, like Rob mentioned, when doing 'make dtbs_check', there is a
warning:
quoted
quoted
/builds/robherring/linux-dt-review/arch/arm/boot/dts/aspeed-ast2500-evb.dt.y
aml:
quoted
quoted
lpc@1e789000: 'ibt@140', 'kcs@114', 'kcs@24', 'kcs@28', 'kcs@2c',
'lhc@a0', 'reg-io-width' do not match any of the regexes:
quoted
quoted
'^lpc-ctrl@[0-9a-f]+$', '^lpc-snoop@[0-9a-f]+$',
'^reset-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
quoted
quoted
From schema:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings
/mfd/aspeed-lpc.yaml

As part of this series has been applied, maybe we can fix this later?
FWIW, this fixes the warnings for me;
--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
@@ -56,6 +56,9 @@ properties:

   ranges: true

+  reg-io-width:
+    const: 4
+
 patternProperties:
   "^lpc-ctrl@[0-9a-f]+$":
     type: object
@@ -144,6 +147,9 @@ patternProperties:
         $ref: /schemas/types.yaml#/definitions/uint32-array
         description: The LPC I/O ports to snoop

+      clocks:
+        maxItems: 1
+
     required:
       - compatible
       - interrupts
make ARCH=arm CROSS_COMPILE="arm-linux-gnueabi-" dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml

If you are able to test this and send a patch that would be appreciated.
Sure. I will test it and send a standalone patch to fix the warning.
Thanks!

Regards,
Chiawei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help