From: Joel Stanley <joel@jms.id.au>
Sent: Thursday, October 21, 2021 2:29 PM

On Fri, 8 Oct 2021 at 04:35, Joel Stanley [off-list ref] wrote:

quoted

On Mon, 27 Sept 2021 at 02:31, Chia-Wei Wang
[off-list ref] wrote:

quoted

The 'reg-io-width' properties are not used by LPC drivers nor
documented as part of bindings. Therefore drop them.

I assume they are there due to the lpc having a 'syscon' compatible.
THey are documented in the syscon bindings:

Documentation/devicetree/bindings/mfd/syscon.yaml

Andrew, do you have any comments?

Andrew indicated to me that he agreed with my observation: the properties
should be present as they are used by the regmap/syscon.

Thanks. Shall we just drop this one and move on with the rest patches?
However, like Rob mentioned, when doing 'make dtbs_check', there is a warning:

/builds/robherring/linux-dt-review/arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml:
lpc@1e789000: 'ibt@140', 'kcs@114', 'kcs@24', 'kcs@28', 'kcs@2c', 'lhc@a0', 'reg-io-width' do not match any of the regexes:
'^lpc-ctrl@[0-9a-f]+$', '^lpc-snoop@[0-9a-f]+$', '^reset-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml

As part of this series has been applied, maybe we can fix this later?

Regards,
Chiawei

quoted

quoted

This is in preparation to move aspeed-lpc.txt to YAML schema.

Signed-off-by: Chia-Wei Wang <redacted>
---
 arch/arm/boot/dts/aspeed-g4.dtsi | 1 -
arch/arm/boot/dts/aspeed-g5.dtsi | 1 -
arch/arm/boot/dts/aspeed-g6.dtsi | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi

b/arch/arm/boot/dts/aspeed-g4.dtsi
index c5aeb3cf3a09..45a25eb4baa4 100644

--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi

@@ -345,7 +345,6 @@
                        lpc: lpc@1e789000 {
                                compatible =

"aspeed,ast2400-lpc-v2", "simple-mfd", "syscon";

quoted

quoted

                                reg = <0x1e789000 0x1000>;
-                               reg-io-width = <4>;

                                #address-cells = <1>;
                                #size-cells = <1>; diff --git
a/arch/arm/boot/dts/aspeed-g5.dtsi
b/arch/arm/boot/dts/aspeed-g5.dtsi
index 73ca1ec6fc24..8e1d00d8445e 100644

--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi

@@ -436,7 +436,6 @@
                        lpc: lpc@1e789000 {
                                compatible =

"aspeed,ast2500-lpc-v2", "simple-mfd", "syscon";

quoted

quoted

                                reg = <0x1e789000 0x1000>;
-                               reg-io-width = <4>;

                                #address-cells = <1>;
                                #size-cells = <1>; diff --git
a/arch/arm/boot/dts/aspeed-g6.dtsi
b/arch/arm/boot/dts/aspeed-g6.dtsi
index 1b47be1704f8..0d1aae6887cd 100644

--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi

@@ -490,7 +490,6 @@
                        lpc: lpc@1e789000 {
                                compatible =

"aspeed,ast2600-lpc-v2", "simple-mfd", "syscon";

quoted

quoted

                                reg = <0x1e789000 0x1000>;
-                               reg-io-width = <4>;

                                #address-cells = <1>;
                                #size-cells = <1>;
--
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel