Re: [PATCH v5 01/14] irqchip: Provide platform_device to of_irq_init_cb_t
From: Marc Zyngier <maz@kernel.org>
Date: 2021-10-20 10:56:15
Also in:
linux-devicetree, linux-mips, lkml
AOn Tue, 19 Oct 2021 22:58:42 +0100, Florian Fainelli [off-list ref] wrote:
Provide the platform device mapping to the interrupt controller node to the of_irq_init_cb_t callback such that drivers can make use of it. Reviewed-by: Rob Herring <robh@kernel.org> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/irqchip/irqchip.c | 2 +- drivers/irqchip/qcom-pdc.c | 3 ++- drivers/of/irq.c | 2 +- include/linux/of_irq.h | 5 ++++- 4 files changed, 8 insertions(+), 4 deletions(-)
[...]
quoted hunk ↗ jump to hunk
diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h index aaf219bd0354..89acc8b089f0 100644 --- a/include/linux/of_irq.h +++ b/include/linux/of_irq.h@@ -9,7 +9,10 @@ #include <linux/ioport.h> #include <linux/of.h> -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); +struct platform_device; + +typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *, + struct platform_device *); /* * Workarounds only applied to 32bit powermac machines
As pointed out in my reply to your v4 [1], this does break all users of IRQCHIP_DECLARE(). You can see that by applying [2]. M. [1] https://lore.kernel.org/r/87tuhcnlwt.wl-maz@kernel.org (local) [2] https://lore.kernel.org/r/20211020104527.3066268-1-maz@kernel.org (local) -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel