Re: [PATCH v2 14/35] mtd: spi-nor: spansion: Use manufacturer late_init()
From: Michael Walle <hidden>
Date: 2021-09-09 22:05:10
Am 2021-07-27 06:52, schrieb Tudor Ambarus:
spansion_post_sfdp_fixups() was called regardless if the flash defined SFDP tables or not. A better place for this kind of parameters init is in manufacturer's late_init() hook. post_sfdp() should be called only when SFDP is defined. No functional change in this patch. Instead of doing the 4b opcodes settings at manufacturer level, thus also for every flash that will be introduced, this should be done just where it is needed, per flash. I'll let this for other patch.
Mh, then why does some flashes define SPI_NOR_4B_OPCODES. It's unclear to me when you would use SPI_NOR_4B_OPCODES and when this individual fixup. Also right now, these SPI_NOR_4B_OPCODES flags for the spansion flashes are superfluous, no? -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel