On Thu, Sep 30, 2021 at 01:09:16PM +0100, German Gomez wrote:

Hi Mathieu,

Thanks for your feedback. I will keep these points in mind for future
submissions.

On 23/09/2021 17:24, Mathieu Poirier wrote:

quoted

Hi German,

On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote:

quoted

[...]

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

A couple of things to improve for your next interactions with the Linux community:

1) Using a cover letter, even for small changes, is always a good idea.
2) RB tags should be picked up publicly rather than done internally and added to
a patchset.
3) Keep patches semantically grouped.  Here patches 04 and 05 have nothing to do
with 01, 02 and 03.

Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05
because
they were related to snapshot mode.

Yes - you are correct.  It should have been 01 and 02 in one set and the rest in
another set.

Thanks,
German

quoted

Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to
this patchset.  As such he will not see your work.  Ask James about how to
proceed when submitting patches to the perf tools.

Thanks,
Mathieu

quoted

  		     cs_etm_decoder__get_name(etmq->decoder), buffer->size);
  	do {
-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel