Re: [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema
From: Krzysztof Kozlowski <hidden>
Date: 2021-08-20 12:49:08
Also in:
linux-devicetree, linux-sunxi, lkml
On 20/08/2021 14:11, Chen-Yu Tsai wrote:
On Fri, Aug 20, 2021 at 4:16 PM Krzysztof Kozlowski [off-list ref] wrote:quoted
Align the name of operating-points node to dtschema to fix warnings like: arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml: cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$' Signed-off-by: Krzysztof Kozlowski <redacted> --- arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi index b2657201957e..0b6914a165b0 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi@@ -2,7 +2,7 @@ // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org> / { - cpu_opp_table: cpu-opp-table { + cpu_opp_table: opp-table-0 {Maybe we should just reorder the name? Name it "opp-table-cpu" instead. That way if and when we add one for the GPU, we don't accidentally clash on the name.
Although the schema allows such name, but still the devicetree specification says that name should be generic (representing generic type of a device). Just like there is a "clock-controller" or "nand-controller", there should be generic "opp-table". Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel