[PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema

Subsystems: arm/allwinner sunxi soc support, the rest

STALE1810d

6 messages, 3 authors, 2021-09-03 · open the first message on its own page

[PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2021-08-20 08:25:58

Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml:
    cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
index b2657201957e..0b6914a165b0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
@@ -2,7 +2,7 @@
 // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org>
 
 / {
-	cpu_opp_table: cpu-opp-table {
+	cpu_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] arm64: dts: allwinner: align thermal zone node names with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2021-08-20 08:25:56

Align the name of thermal zone node to dtschema to fix warnings like:

  arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dt.yaml:
    thermal-zones: 'cpu-thermal-zone', 'ddr-thermal-zone', 'gpu-thermal-zone' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 6 +++---
 arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
index cc321c04f121..f6d7d7f7fdab 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
@@ -343,19 +343,19 @@ r_i2c1: i2c@7081800 {
 	};
 
 	thermal-zones {
-		cpu-thermal-zone {
+		cpu-thermal {
 			polling-delay-passive = <0>;
 			polling-delay = <0>;
 			thermal-sensors = <&ths 0>;
 		};
 
-		ddr-thermal-zone {
+		ddr-thermal {
 			polling-delay-passive = <0>;
 			polling-delay = <0>;
 			thermal-sensors = <&ths 2>;
 		};
 
-		gpu-thermal-zone {
+		gpu-thermal {
 			polling-delay-passive = <0>;
 			polling-delay = <0>;
 			thermal-sensors = <&ths 1>;
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
index 578a63dedf46..9988e87ea7b3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
@@ -217,7 +217,7 @@ cpu-hot-limit {
 			};
 		};
 
-		gpu_thermal {
+		gpu-thermal {
 			polling-delay-passive = <0>;
 			polling-delay = <0>;
 			thermal-sensors = <&ths 1>;
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: allwinner: align thermal zone node names with dtschema

From: Chen-Yu Tsai <hidden>
Date: 2021-08-20 12:06:26

On Fri, Aug 20, 2021 at 4:17 PM Krzysztof Kozlowski
[off-list ref] wrote:
Align the name of thermal zone node to dtschema to fix warnings like:

  arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dt.yaml:
    thermal-zones: 'cpu-thermal-zone', 'ddr-thermal-zone', 'gpu-thermal-zone' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <redacted>
Acked-by: Chen-Yu Tsai <redacted>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema

From: Chen-Yu Tsai <hidden>
Date: 2021-08-20 12:11:30

On Fri, Aug 20, 2021 at 4:16 PM Krzysztof Kozlowski
[off-list ref] wrote:
quoted hunk
Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml:
    cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
index b2657201957e..0b6914a165b0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
@@ -2,7 +2,7 @@
 // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org>

 / {
-       cpu_opp_table: cpu-opp-table {
+       cpu_opp_table: opp-table-0 {
Maybe we should just reorder the name? Name it "opp-table-cpu" instead.
That way if and when we add one for the GPU, we don't accidentally
clash on the name.


ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2021-08-20 12:49:08

On 20/08/2021 14:11, Chen-Yu Tsai wrote:
On Fri, Aug 20, 2021 at 4:16 PM Krzysztof Kozlowski
[off-list ref] wrote:
quoted
Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml:
    cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
index b2657201957e..0b6914a165b0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
@@ -2,7 +2,7 @@
 // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org>

 / {
-       cpu_opp_table: cpu-opp-table {
+       cpu_opp_table: opp-table-0 {
Maybe we should just reorder the name? Name it "opp-table-cpu" instead.
That way if and when we add one for the GPU, we don't accidentally
clash on the name.
Although the schema allows such name, but still the devicetree
specification says that name should be generic (representing generic
type of a device). Just like there is a "clock-controller" or
"nand-controller", there should be generic "opp-table".


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema

From: Maxime Ripard <hidden>
Date: 2021-09-03 16:21:37

On Fri, Aug 20, 2021 at 10:16:44AM +0200, Krzysztof Kozlowski wrote:
Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml:
    cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'

Signed-off-by: Krzysztof Kozlowski <redacted>
I already sent those patches a few weeks ago:
https://lore.kernel.org/linux-arm-kernel/20210721140424.725744-43-maxime@cerno.tech/
https://lore.kernel.org/linux-arm-kernel/20210721140424.725744-48-maxime@cerno.tech/
https://lore.kernel.org/linux-arm-kernel/20210721140424.725744-50-maxime@cerno.tech/

I sent a v2 last week, and will merge them soon

Thanks!
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help