Re: [PATCH] ARM: atags_to_fdt: don't warn about stack size
From: Nicolas Pitre <nico@fluxnic.net>
Date: 2021-08-09 15:25:59
Also in:
lkml
On Mon, 9 Aug 2021, David Heidelberg wrote:
The merge_fdt_bootargs() function by definition consumes more than 1024 bytes of stack because it has a 1024 byte command line on the stack, meaning that we always get a warning when building this file: arch/arm/boot/compressed/atags_to_fdt.c: In function 'merge_fdt_bootargs': arch/arm/boot/compressed/atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] However, as this is the decompressor and we know that it has a very shallow call chain, and we do not actually risk overflowing the kernel stack at runtime here. This just shuts up the warning by disabling the warning flag for this file. Tested on Nexus 7 2012 builds. Original Author: Arnd Bergmann [off-list ref] Reference: https://lore.kernel.org/lkml/8232115.18ykgQ6J5T@wuerfel/ (local) Cc: Arnd Bergmann <arnd@arndb.de> Cc: Nicolas Pitre <redacted> Cc: Russell King <redacted> Cc: Ard Biesheuvel <redacted> Cc: Marc Zyngier <redacted> Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: David Heidelberg <david@ixit.cz>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
quoted hunk ↗ jump to hunk
--- arch/arm/boot/compressed/Makefile | 2 ++ 1 file changed, 2 insertions(+)diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index 9d91ae1091b0..91265e7ff672 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile@@ -85,6 +85,8 @@ compress-$(CONFIG_KERNEL_LZ4) = lz4 libfdt_objs := fdt_rw.o fdt_ro.o fdt_wip.o fdt.o ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y) +CFLAGS_REMOVE_atags_to_fdt.o += -Wframe-larger-than=${CONFIG_FRAME_WARN} +CFLAGS_atags_to_fdt.o += -Wframe-larger-than=1280 OBJS += $(libfdt_objs) atags_to_fdt.o endif ifeq ($(CONFIG_USE_OF),y)-- 2.30.2
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel