From: David Heidelberg <david@ixit.cz> Date: 2021-08-09 15:11:39
The merge_fdt_bootargs() function by definition consumes more than 1024
bytes of stack because it has a 1024 byte command line on the stack,
meaning that we always get a warning when building this file:
arch/arm/boot/compressed/atags_to_fdt.c: In function 'merge_fdt_bootargs':
arch/arm/boot/compressed/atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
However, as this is the decompressor and we know that it has a very shallow
call chain, and we do not actually risk overflowing the kernel stack
at runtime here.
This just shuts up the warning by disabling the warning flag for this
file.
Tested on Nexus 7 2012 builds.
Original Author: Arnd Bergmann [off-list ref]
Reference: https://lore.kernel.org/lkml/8232115.18ykgQ6J5T@wuerfel/
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Pitre <redacted>
Cc: Russell King <redacted>
Cc: Ard Biesheuvel <redacted>
Cc: Marc Zyngier <redacted>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm/boot/compressed/Makefile | 2 ++
1 file changed, 2 insertions(+)
From: "Russell King (Oracle)" <linux@armlinux.org.uk> Date: 2021-08-09 15:24:34
On Mon, Aug 09, 2021 at 05:10:21PM +0200, David Heidelberg wrote:
The merge_fdt_bootargs() function by definition consumes more than 1024
bytes of stack because it has a 1024 byte command line on the stack,
meaning that we always get a warning when building this file:
arch/arm/boot/compressed/atags_to_fdt.c: In function 'merge_fdt_bootargs':
arch/arm/boot/compressed/atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
However, as this is the decompressor and we know that it has a very shallow
call chain, and we do not actually risk overflowing the kernel stack
at runtime here.
This just shuts up the warning by disabling the warning flag for this
file.
Tested on Nexus 7 2012 builds.
Original Author: Arnd Bergmann [off-list ref]
Reference: https://lore.kernel.org/lkml/8232115.18ykgQ6J5T@wuerfel/
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Pitre <redacted>
Cc: Russell King <redacted>
Cc: Ard Biesheuvel <redacted>
Cc: Marc Zyngier <redacted>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: David Heidelberg <david@ixit.cz>
I assume Arnd never sent his v3 from what I see in the thread you link
to above.
This needs to go to the patch system to be applied. Details in my
signature below. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Nicolas Pitre <nico@fluxnic.net> Date: 2021-08-09 15:25:59
On Mon, 9 Aug 2021, David Heidelberg wrote:
The merge_fdt_bootargs() function by definition consumes more than 1024
bytes of stack because it has a 1024 byte command line on the stack,
meaning that we always get a warning when building this file:
arch/arm/boot/compressed/atags_to_fdt.c: In function 'merge_fdt_bootargs':
arch/arm/boot/compressed/atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
However, as this is the decompressor and we know that it has a very shallow
call chain, and we do not actually risk overflowing the kernel stack
at runtime here.
This just shuts up the warning by disabling the warning flag for this
file.
Tested on Nexus 7 2012 builds.
Original Author: Arnd Bergmann [off-list ref]
Reference: https://lore.kernel.org/lkml/8232115.18ykgQ6J5T@wuerfel/
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Pitre <redacted>
Cc: Russell King <redacted>
Cc: Ard Biesheuvel <redacted>
Cc: Marc Zyngier <redacted>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: David Heidelberg <david@ixit.cz>
On Mon, Aug 9, 2021 at 5:24 PM Russell King (Oracle)
[off-list ref] wrote:
On Mon, Aug 09, 2021 at 05:10:21PM +0200, David Heidelberg wrote:
quoted
Signed-off-by: David Heidelberg <david@ixit.cz>
Acked-by: Arnd Bergmann <arnd@arndb.de>
(or keep my original Signed-off-by if you like)
I assume Arnd never sent his v3 from what I see in the thread you link
to above.
Yes, it's in my ever-growing backlog of things I plan to eventually resubmit.
In this case, I actually have a different patch in my tree, but that in turn
depends on other stuff I have to submit first (reorganizing the way that
warning options get handled based on compiler version etc), and the
version here is what works on current mainline kernels.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: David Heidelberg <david@ixit.cz> Date: 2021-08-09 16:45:06
Thank you, in next iteration I'll keep you as author and keep your S-off-by
-------- Původní zpráva --------
Odesílatel: Arnd Bergmann [off-list ref]
Odesláno: 9. srpna 2021 16:02:36 UTC
Komu: "Russell King (Oracle)" [off-list ref]
Kopie: David Heidelberg [off-list ref], Arnd Bergmann [off-list ref], Jon Medhurst [off-list ref], Ard Biesheuvel [off-list ref], Marc Zyngier [off-list ref], Nicolas Pitre [off-list ref], Linux Kernel Mailing List [off-list ref], Linux ARM [off-list ref]
Předmět: Re: [PATCH] ARM: atags_to_fdt: don't warn about stack size
On Mon, Aug 9, 2021 at 5:24 PM Russell King (Oracle)
[off-list ref] wrote:
On Mon, Aug 09, 2021 at 05:10:21PM +0200, David Heidelberg wrote:
quoted
Signed-off-by: David Heidelberg <david@ixit.cz>
Acked-by: Arnd Bergmann <arnd@arndb.de>
(or keep my original Signed-off-by if you like)
I assume Arnd never sent his v3 from what I see in the thread you link
to above.
Yes, it's in my ever-growing backlog of things I plan to eventually resubmit.
In this case, I actually have a different patch in my tree, but that in turn
depends on other stuff I have to submit first (reorganizing the way that
warning options get handled based on compiler version etc), and the
version here is what works on current mainline kernels.
Arnd
S pozdravem a přáním krásného dne
David Heidelberg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel