Re: [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram
From: Dong Aisheng <hidden>
Date: 2021-07-08 08:15:49
Also in:
linux-remoteproc
On Wed, Jul 7, 2021 at 5:41 PM Dong Aisheng [off-list ref] wrote:
DRAM is not io memory, so changed to ioremap_wc. This is also aligned with core io accessories. e.g. memcpy/memset and cpu direct access. Cc: Bjorn Andersson <redacted> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
[...]
Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted before Linux Kernel")
Reviewed-by: Peng Fan <peng.fan@nxp.com>Above two lines were added by mistake. (copied from patch 4) I'm going to wait for review comments first and resend with changes if any. Regards Aisheng
quoted hunk ↗ jump to hunk
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- v1->v2: * new patch --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c@@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, break; /* Not use resource version, because we might share region */ - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res)); if (!priv->mem[b].cpu_addr) { dev_err(dev, "failed to remap %pr\n", &res); return -ENOMEM; --2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel