Re: [RFC PATCH 01/10] firmware: arm_scmi: Reset properly xfer SCMI status
From: Sudeep Holla <hidden>
Date: 2021-06-07 17:38:33
Also in:
lkml
On Sun, Jun 06, 2021 at 11:12:23PM +0100, Cristian Marussi wrote:
When an SCMI command transfer fails due to some protocol issue an SCMI error code is reported inside the SCMI message payload itself and it is then retrieved and transcribed by the specific transport layer into the xfer.hdr.status field by transport specific .fetch_response(). The core SCMI transport layer never explicitly reset xfer.hdr.status, so when an xfer is reused, if a transport misbehaved in handling such status field, we risk to see an invalid ghost error code. Reset xfer.hdr.status to SCMI_SUCCESS right before each transfer is started.
Any particular reason why it can't be part of xfer_get_init which has other initialisations ? If none, please move it there. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel