Re: [PATCH v3 4/5] gpio: gpio-aspeed-sgpio: Add set_config function

The 06/03/2021 19:07, Andy Shevchenko wrote:

On Thu, Jun 3, 2021 at 1:20 PM Steven Lee [off-list ref] wrote:

quoted

AST SoC supports *retain pin state* function when wdt reset.
The patch adds set_config function for handling sgpio reset tolerance
register.

...

quoted

+static int aspeed_sgpio_set_config(struct gpio_chip *chip, unsigned int offset,
+                                  unsigned long config)
+{
+       unsigned long param = pinconf_to_config_param(config);
+       u32 arg = pinconf_to_config_argument(config);
+
+       if (param == PIN_CONFIG_PERSIST_STATE)
+               return aspeed_sgpio_reset_tolerance(chip, offset, arg);

quoted

+       else

Redundant.

quoted

+               return -EOPNOTSUPP;

IIRC we are using ENOTSUPP internally in the kernel. YEs, checkpatch
warning may be ignored.

quoted

+}

I will modify the code as you suggested above, thanks.

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel