Thread (18 messages) 18 messages, 4 authors, 2021-06-09

Re: [PATCH v3 4/5] gpio: gpio-aspeed-sgpio: Add set_config function

From: Andy Shevchenko <hidden>
Date: 2021-06-03 11:08:55
Also in: linux-aspeed, linux-devicetree, linux-gpio, lkml

On Thu, Jun 3, 2021 at 1:20 PM Steven Lee [off-list ref] wrote:
AST SoC supports *retain pin state* function when wdt reset.
The patch adds set_config function for handling sgpio reset tolerance
register.
...
+static int aspeed_sgpio_set_config(struct gpio_chip *chip, unsigned int offset,
+                                  unsigned long config)
+{
+       unsigned long param = pinconf_to_config_param(config);
+       u32 arg = pinconf_to_config_argument(config);
+
+       if (param == PIN_CONFIG_PERSIST_STATE)
+               return aspeed_sgpio_reset_tolerance(chip, offset, arg);
+       else
Redundant.
+               return -EOPNOTSUPP;
IIRC we are using ENOTSUPP internally in the kernel. YEs, checkpatch
warning may be ignored.
+}
-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help