[PATCH v3 01/14] spi: pxa2xx: Use one point of return when ->probe() fails
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-05-10 13:02:54
Also in:
alsa-devel, linux-spi, lkml
Subsystem:
intel lpss (low power subsystem) drivers, pxa2xx/pxa3xx support, spi subsystem, the rest · Maintainers:
Daniel Mack, Haojian Zhuang, Robert Jarzmik, Mark Brown, Linus Torvalds
When we can't allocate SPI controller, jump to the error path rather than return locally. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/spi/spi-pxa2xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 5e59ba075bc7..2f5618883ac3 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c@@ -1705,8 +1705,8 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) if (!controller) { dev_err(&pdev->dev, "cannot alloc spi_controller\n"); - pxa_ssp_free(ssp); - return -ENOMEM; + status = -ENOMEM; + goto out_error_controller_alloc; } drv_data = spi_controller_get_devdata(controller); drv_data->controller = controller;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel