Thread (21 messages) 21 messages, 5 authors, 2021-06-03

Re: [PATCH v4 0/3] gpio: gpio-regmap: Support few custom operations

From: Michael Walle <hidden>
Date: 2021-05-28 17:23:28
Also in: linux-gpio, lkml

Hi Matti,

Am 2021-05-28 17:42, schrieb Vaittinen, Matti:
Hi Bartosz,

On Fri, 2021-05-28 at 16:31 +0200, Bartosz Golaszewski wrote:
quoted
On Fri, May 28, 2021 at 8:33 AM Vaittinen, Matti
[off-list ref] wrote:

[snip]
quoted
quoted
What makes things easy for me to maintain is active and happy
driver maintainers, so it is paramount that the file looks to
Michael
like something he wants to keep maintaining. This removes work
from me and Bartosz.
I agree. When someone takes care of a driver, he should be happy
with
it. Period. And thanks to Michael for writing this driver and
reviewing
the patches. Reviewing is hard work.

On the other hand, I don't enjoy writing code I am unhappy with
either.
And as this particular piece of code is not a paid task for me, I
do
this for fun. gpio-regmap is not mandatory for my drivers now. So,
I'll
just opt-out from this change. I'll happily use the gpio-regmap
where
it fits, when it fits.
I take it that path 2/3 is still good to go?
I don't think it had explicit ack from Michael yet - but I think it was
not objected either. I can respin it alone if needed but would help me
if you just pick it from this series (assuming it's Ok for others).
Just sent my R-b.

I'd pick the removal of the gpio_regmap_set_drvdata(), too. If you're
fine with it I'd submit a new patch with just that.

-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help