Re: [PATCH] ACPI/IORT: Handle device properties with software node API
From: Lorenzo Pieralisi <hidden>
Date: 2021-05-14 10:39:21
Also in:
linux-acpi, lkml
On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().
Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")Is this really fixing anything ? I am not sure I understand what you would like to achieve with this tag.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> --- drivers/acpi/arm64/iort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
With the above comment clarified: Acked-by: Lorenzo Pieralisi <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c index 3912a1f6058e5..e34937e11186a 100644 --- a/drivers/acpi/arm64/iort.c +++ b/drivers/acpi/arm64/iort.c@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev, FIELD_GET(ACPI_IORT_NC_PASID_BITS, nc->node_flags)); - if (device_add_properties(dev, props)) + if (device_create_managed_software_node(dev, props, NULL)) dev_warn(dev, "Could not add device properties\n"); }-- 2.30.2
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel