[PATCH] ACPI/IORT: Handle device properties with software node API

Subsystems: acpi, the rest

STALE1933d

6 messages, 4 authors, 2021-05-17 · open the first message on its own page

[PATCH] ACPI/IORT: Handle device properties with software node API

From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Date: 2021-05-11 12:55:15 

The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().

Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/acpi/arm64/iort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 3912a1f6058e5..e34937e11186a 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
 				      FIELD_GET(ACPI_IORT_NC_PASID_BITS,
 						nc->node_flags));
 
-	if (device_add_properties(dev, props))
+	if (device_create_managed_software_node(dev, props, NULL))
 		dev_warn(dev, "Could not add device properties\n");
 }
 
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ACPI/IORT: Handle device properties with software node API

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-05-11 13:52:15 

On Tue, May 11, 2021 at 2:55 PM Heikki Krogerus
[off-list ref] wrote:
quoted hunk
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().

Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/acpi/arm64/iort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 3912a1f6058e5..e34937e11186a 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
                                      FIELD_GET(ACPI_IORT_NC_PASID_BITS,
                                                nc->node_flags));

-       if (device_add_properties(dev, props))
+       if (device_create_managed_software_node(dev, props, NULL))
                dev_warn(dev, "Could not add device properties\n");
 }

--
Thanks!

I can take this through the ACPI tree if there are no objections.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ACPI/IORT: Handle device properties with software node API

From: Hanjun Guo <guohanjun@huawei.com>
Date: 2021-05-14 00:42:46 

On 2021/5/11 21:51, Rafael J. Wysocki wrote:
On Tue, May 11, 2021 at 2:55 PM Heikki Krogerus
[off-list ref]  wrote:
quoted
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().

Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Signed-off-by: Heikki Krogerus<heikki.krogerus@linux.intel.com>
---
  drivers/acpi/arm64/iort.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 3912a1f6058e5..e34937e11186a 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
                                       FIELD_GET(ACPI_IORT_NC_PASID_BITS,
                                                 nc->node_flags));

-       if (device_add_properties(dev, props))
+       if (device_create_managed_software_node(dev, props, NULL))
                 dev_warn(dev, "Could not add device properties\n");
  }

--
Thanks!

I can take this through the ACPI tree if there are no objections.
Since this is related to device property API refactor, I'm
fine with it.

Lorenzo, what's your position?

Thanks
Hanjun

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ACPI/IORT: Handle device properties with software node API

From: Lorenzo Pieralisi <hidden>
Date: 2021-05-14 10:39:21 

On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().

Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Is this really fixing anything ? I am not sure I understand what you
would like to achieve with this tag.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/acpi/arm64/iort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
With the above comment clarified:

Acked-by: Lorenzo Pieralisi <redacted>
quoted hunk
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 3912a1f6058e5..e34937e11186a 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
 				      FIELD_GET(ACPI_IORT_NC_PASID_BITS,
 						nc->node_flags));
 
-	if (device_add_properties(dev, props))
+	if (device_create_managed_software_node(dev, props, NULL))
 		dev_warn(dev, "Could not add device properties\n");
 }
 
-- 
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ACPI/IORT: Handle device properties with software node API

From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Date: 2021-05-14 13:13:39 

On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote:
On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
quoted
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().

Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Is this really fixing anything ? I am not sure I understand what you
would like to achieve with this tag.
Right now it's not possible to simply remove the old API because some
of the maintainers want to take care of the conversion themselves, but
at the same time I also do not want to see any new releases of the
kernel that introduce more users for it. That's why it's a fix.
quoted
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/acpi/arm64/iort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
With the above comment clarified:

Acked-by: Lorenzo Pieralisi <redacted>
quoted
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 3912a1f6058e5..e34937e11186a 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
 				      FIELD_GET(ACPI_IORT_NC_PASID_BITS,
 						nc->node_flags));
 
-	if (device_add_properties(dev, props))
+	if (device_create_managed_software_node(dev, props, NULL))
 		dev_warn(dev, "Could not add device properties\n");
 }
 
-- 
2.30.2
thanks,

-- 
heikki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ACPI/IORT: Handle device properties with software node API

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-05-17 14:45:01 

On Fri, May 14, 2021 at 3:13 PM Heikki Krogerus
[off-list ref] wrote:
On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote:
quoted
On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote:
quoted
The older device property API is going to be removed.
Replacing the device_add_properties() call with software
node API equivalent device_create_managed_software_node().

Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
Is this really fixing anything ? I am not sure I understand what you
would like to achieve with this tag.
Right now it's not possible to simply remove the old API because some
of the maintainers want to take care of the conversion themselves, but
at the same time I also do not want to see any new releases of the
kernel that introduce more users for it. That's why it's a fix.
With the assumption that the above clarification is sufficient,
applied as 5.14 material, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help