Re: [External] : Re: [PATCH v14 4/6] locking/qspinlock: Introduce starvation avoidance into CNA
From: Andi Kleen <hidden>
Date: 2021-04-13 21:22:11
Also in:
linux-arch, lkml
From: Andi Kleen <hidden>
Date: 2021-04-13 21:22:11
Also in:
linux-arch, lkml
quoted
ms granularity seems very coarse grained for this. Surely at some point of spinning you can afford a ktime_get? But ok.We are reading time when we are at the head of the (main) queue, but don’t have the lock yet. Not sure about the latency of ktime_get(), but anything reasonably fast but not necessarily precise should work.
Actually cpu_clock / sched_clock (see my other email). These should be fast without corner cases and also monotonic.
quoted
Could you turn that into a moduleparm which can be changed at runtime? Would be strange to have to reboot just to play with this parameterYes, good suggestion, thanks.quoted
This would also make the code a lot shorter I guess.So you don’t think we need the command-line parameter, just the module_param?
module_params can be changed at the command line too, so yes. -Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel