On 3/23/21 11:04 PM, Srinivas Neeli wrote:

Hi Guenter,

Thanks for review

quoted

-----Original Message-----
From: Guenter Roeck <redacted> On Behalf Of Guenter Roeck
Sent: Tuesday, March 16, 2021 8:01 AM
To: Srinivas Neeli <redacted>; Michal Simek <redacted>;
Shubhrajyoti Datta [off-list ref]; Srinivas Goud
[off-list ref]
Cc: wim@linux-watchdog.org; linux-watchdog@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git
[off-list ref]
Subject: Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window
watchdog support

On 3/15/21 3:46 AM, Srinivas Neeli wrote:

quoted

Versal watchdog driver uses Window watchdog mode. Window watchdog
timer(WWDT) contains closed(first) and open(second) window with
32 bit width. WWDT will generate an interrupt after the first window
timeout and reset signal after the second window timeout. Timeout and
Pre-timeout configuration, Stop and Refresh trigger only in open
window.

Signed-off-by: Srinivas Neeli <redacted>

I think this should be a separate watchdog driver. There is pretty much no
overlap with the existing driver.

Xilinx AXI Timebase Watchdog Timer supports two independent modes
1)Timebase Watchdog Mode
2)Window Watchdog Timer Mode.
Current of_xilinx_wdt.c driver already have support for Timebase Watchdog Mode, but Window watchdog timer Mode feature is missing.
Versal platform contains customized AXI Timebase Watchdog Timer, which supports Window Watchdog Timer Mode.
For that reason we are creating common driver for both the modes.

That is not an argument. The two watchdogs are still completely different,
and there is no value having a single driver.

Guenter

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel