Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

On Fri, Feb 19, 2021 at 03:03:55PM +0100, Adrien Grassein wrote:

Le ven. 19 févr. 2021 à 14:18, Krzysztof Kozlowski [off-list ref] a écrit :

quoted

On Wed, Feb 17, 2021 at 05:10:45PM +0100, Adrien Grassein wrote:

quoted

Add usdhc3 description which corresponds to the wifi/bt chip

Signed-off-by: Adrien Grassein <redacted>
---
 .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
index c0c384d76147..212dc9e5e85d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts

@@ -9,6 +9,17 @@
 / {
      model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
      compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
+
+     reg_wlan_vmmc: regulator-wlan-vmmc {
+             compatible = "regulator-fixed";
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_reg_wlan_vmmc>;
+             regulator-name = "reg_wlan_vmmc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
 };

 &A53_0 {

@@ -206,6 +217,20 @@ &usdhc2 {
      status = "okay";
 };

+/* wlan */
+&usdhc3 {
+     bus-width = <4>;
+     sdhci-caps-mask = <0x2 0x0>;
+     non-removable;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc3>;
+     pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+     vmmc-supply = <&reg_wlan_vmmc>;
+     vqmmc-1-8-v;

There is no such property in the bindings.

Sorry, I copied a property from the FSL kernel.
I will fix this with a "fixed-regulator".

I would assume this goes from PMIC, so check your schematics. There is
little point in adding a fixed regulator which is non-controllable.
I think bindings don't require it.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel