Re: [PATCH v1 5/7] ARM i.MX6q: remove Atheros AR8035 SmartEEE fixup
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-02-08 09:38:19
Also in:
lkml, netdev
On Wed, Feb 03, 2021 at 09:56:28AM +0000, Russell King - ARM Linux admin wrote:
On Wed, Feb 03, 2021 at 10:18:55AM +0100, Oleksij Rempel wrote:quoted
This fixup removes the Lpi_en bit. If this patch breaks functionality of your board, use following device tree properties: ethernet-phy@X { reg = <0xX>; eee-broken-1000t; eee-broken-100tx; .... };That is the historical fix for this problem, but there is a better solution now in net-next - configuring the Tw parameter for gigabit connections. That solves the random link drop issue when EEE is enabled.
Do you mean this properties? qca,smarteee-tw-us-1g qca,smarteee-tw-us-100m Do you have some recommendations, which values can be here used? Are they same for all MACs? Or, can we calculate this values automatically? Beside, I have seen this patch: "ARM: dts: imx6qdl-sr-som: fix some cubox-i platforms" I had similar issue and it was triggered by the boot loader, which enabled 60 Ohm on-die termination. The fix was to remove this lines in the boot loader: wm 32 0x020e07ac 0x00000200 /* 60 Ohm ODT */
Support for this configuration has only recently been merged into net-next and other trees for this merge window, so I ask that you hold off at least this patch until the next cycle.
ok. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel