Thread (15 messages) 15 messages, 2 authors, 2021-01-13

Re: [PATCH v3 7/7] pwm: rockchip: Enable clock before calling clk_get_rate()

From: Uwe Kleine-König <hidden>
Date: 2021-01-13 07:56:01
Also in: linux-pwm, linux-rockchip

On Wed, Dec 23, 2020 at 11:01:09AM -0500, Simon South wrote:
The documentation for clk_get_rate() in include/linux/clk.h states the
function's result is valid only for a clock source that has been
enabled. However, the Rockchip PWM driver uses this function in two places
to query the rate of a clock without first ensuring it is enabled.

Fix this by modifying rockchip_pwm_get_state() and rockchip_pwm_apply() so
they enable a device's PWM clock before querying its rate (in the latter
case, the querying is actually done in rockchip_pwm_config()) and disable
the clock again before returning.

Reported-by: Uwe Kleine-König <redacted>
Signed-off-by: Simon South <redacted>
Reviewed-by: Uwe Kleine-König <redacted>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help