Re: [PATCH v3 5/7] pwm: rockchip: rockchip_pwm_probe(): Remove unneeded goto target

[PATCH v3 0/7] pwm: rockchip: Eliminate potential race condition when probing · Simon South <hidden> · 2020-12-23
[PATCH v3 1/7] pwm: rockchip: Enable APB clock during register access while probing · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 1/7] pwm: rockchip: Enable APB clock during register access while probing · Uwe Kleine-König <hidden> · 2021-01-13
[PATCH v3 2/7] pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare() · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 2/7] pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare() · Uwe Kleine-König <hidden> · 2021-01-13
[PATCH v3 3/7] pwm: rockchip: Replace "bus clk" with "PWM clk" · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 3/7] pwm: rockchip: Replace "bus clk" with "PWM clk" · Uwe Kleine-König <hidden> · 2021-01-13
[PATCH v3 4/7] pwm: rockchip: Eliminate potential race condition when probing · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 4/7] pwm: rockchip: Eliminate potential race condition when probing · Uwe Kleine-König <hidden> · 2021-01-13
[PATCH v3 5/7] pwm: rockchip: rockchip_pwm_probe(): Remove unneeded goto target · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 5/7] pwm: rockchip: rockchip_pwm_probe(): Remove unneeded goto target · Uwe Kleine-König <hidden> · 2021-01-13
[PATCH v3 6/7] pwm: rockchip: Enable PWM clock of probed device only if running · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 6/7] pwm: rockchip: Enable PWM clock of probed device only if running · Uwe Kleine-König <hidden> · 2021-01-13
[PATCH v3 7/7] pwm: rockchip: Enable clock before calling clk_get_rate() · Simon South <hidden> · 2020-12-23
Re: [PATCH v3 7/7] pwm: rockchip: Enable clock before calling clk_get_rate() · Uwe Kleine-König <hidden> · 2021-01-13

From: Uwe Kleine-König <hidden>
Date: 2021-01-13 07:39:57
Also in: linux-pwm, linux-rockchip

On Wed, Dec 23, 2020 at 11:01:07AM -0500, Simon South wrote:

Eliminate the remaining goto target in rockchip_pwm_probe() by moving the
code that follows it to the point where it is invoked.

The target no longer serves any purpose as the error-handling portions of
this function no longer share any recovery steps.

If you adapt patch 4 as I suggested, this patch becomes obsolete.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help