Re: [PATCH 03/13] opp: Keep track of currently programmed OPP

[PATCH 00/13] opp: Implement dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 01/13] opp: Rename _opp_set_rate_zero() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 03/13] opp: Keep track of currently programmed OPP · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Dmitry Osipenko <digetx@gmail.com> · 2021-01-21
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-22
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Dmitry Osipenko <digetx@gmail.com> · 2021-01-22
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-25
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Ionela Voinescu <hidden> · 2021-07-07
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Viresh Kumar <viresh.kumar@linaro.org> · 2021-07-08
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Ionela Voinescu <hidden> · 2021-07-09
Re: [PATCH 03/13] opp: Keep track of currently programmed OPP · Viresh Kumar <viresh.kumar@linaro.org> · 2021-07-12
[PATCH 08/13] opp: Update parameters of _set_opp_custom() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 10/13] cpufreq: qcom: Migrate to dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() · Dmitry Osipenko <digetx@gmail.com> · 2021-01-21
Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-22
Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() · Dmitry Osipenko <digetx@gmail.com> · 2021-01-22
Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-25
Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() · Dmitry Osipenko <digetx@gmail.com> · 2021-01-26
[PATCH 12/13] drm: msm: Migrate to dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 13/13] opp: Remove dev_pm_opp_set_bw() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 09/13] opp: Implement dev_pm_opp_set_opp() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices · Dmitry Osipenko <digetx@gmail.com> · 2021-01-21
Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-22
Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices · Dmitry Osipenko <digetx@gmail.com> · 2021-01-25
Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-27
[PATCH 06/13] opp: Allow _generic_set_opp_regulator() to work for non-freq devices · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 05/13] opp: Allow _set_opp() to work for non-freq devices · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 04/13] opp: Split _set_opp() out of dev_pm_opp_set_rate() · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21
[PATCH 02/13] opp: No need to check clk for errors · Viresh Kumar <viresh.kumar@linaro.org> · 2021-01-21

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-01-21 21:45:11
Also in: linux-pm, lkml

21.01.2021 14:17, Viresh Kumar пишет:

quoted hunk ↗ jump to hunk

@@ -1074,15 +1091,18 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
 
 	if (!ret) {
 		ret = _set_opp_bw(opp_table, opp, dev, false);
-		if (!ret)
+		if (!ret) {
 			opp_table->enabled = true;
+			dev_pm_opp_put(old_opp);
+
+			/* Make sure current_opp doesn't get freed */
+			dev_pm_opp_get(opp);
+			opp_table->current_opp = opp;
+		}
 	}

I'm a bit surprised that _set_opp_bw() isn't used similarly to
_set_opp_voltage() in _generic_set_opp_regulator().

I'd expect the BW requirement to be raised before the clock rate goes UP.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help