Thread (47 messages) 47 messages, 8 authors, 2021-01-26

Re: [PATCH v3 02/21] mmc: sunxi: add support for A100 mmc controller

From: Maxime Ripard <hidden>
Date: 2021-01-21 16:45:03
Also in: lkml

Hi Andre,

On Mon, Jan 18, 2021 at 03:52:28PM +0000, Andre Przywara wrote:
On Mon, 18 Jan 2021 14:28:54 +0100
Maxime Ripard [off-list ref] wrote:

Hi Maxime,
quoted
On Mon, Jan 18, 2021 at 02:08:29AM +0000, Andre Przywara wrote:
quoted
From: Yangtao Li <redacted>

This patch adds support for A100 MMC controller, which use word
address for internal dma.

Signed-off-by: Yangtao Li <redacted>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>  
We should also disable the timings setup in probe to derive them from
the DT. This is causing issues on some SoCs already, so it would be
best to not make the situation worse
But only for those new SoCs, where we have the speed modes in the DT
in every case (so only new ones)? And this disabling would be
SoC/compatible string dependent? Happy to send a patch later if that is
what you were thinking about.
Yeah, we should only do it for new SoCs at the moment, based on the
compatible.

I guess at some point we'll have to remove it for the older SoCs as well
since we have reports of it failing for SoCs as old as the A20, but
we'll probably want to make it as smooth as possible.

Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help