Re: [RFC PATCH 4/8] mm: Separate fault info out of 'struct vm_fault'

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
2021-01-14 18:17:16
Also in
linux-mm, lkml
On Thu, Jan 14, 2021 at 10:01 AM Will Deacon [off-list ref] wrote:
Try to clean this up by splitting the immutable fault information out
into a new 'struct vm_fault_info' which is embedded in 'struct vm_fault'
and will later be made 'const'. The vast majority of this change was
performed with a coccinelle patch:
You may have a reason for doing it this way, but my reaction to this
was: "just make the new embedded struct unnamed".

Then you wouldn't need to do all the automated coccinelle changes.

Is there some reason you didn't do that, or just a "oh, I didn't think of it".

                Linus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (9 messages) 9 messages, 3 authors, last reply 2021-01-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help