Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes
From: Rob Herring <robh@kernel.org>
Date: 2021-01-11 21:51:02
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote:
Add maxim,max8997-battery and maxim,max8997-muic optional nodes. Signed-off-by: Timon Baetz <redacted> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> --- v6: No change. v5: No change. v4: Make extcon and charger-supply optional. v3: Reorder patch, no change. v2: Add patch. .../bindings/regulator/max8997-regulator.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)
This exceeds my threshold of changes for please convert this to schema first. However, I agree with what Mark has said already, so maybe some of this isn't needed.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt index 6fe825b8ac1b..faaf2bbf0272 100644 --- a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt@@ -53,6 +53,18 @@ Additional properties required if either of the optional properties are used: - max8997,pmic-buck125-dvs-gpios: GPIO specifiers for three host gpio's used for dvs. The format of the gpio specifier depends in the gpio controller. +Optional nodes: +- charger: Node for configuring the charger driver. + Required properties: + - compatible: "maxim,max8997-battery" + Optional properties: + - extcon: extcon specifier for charging events
Don't use 'extcon' for new bindings. Define a connector node. USB I suppose?
+ - charger-supply: regulator node for charging current + +- muic: Node used only by extcon consumers. + Required properties: + - compatible: "maxim,max8997-muic" + Regulators: The regulators of max8997 that have to be instantiated should be included in a sub-node named 'regulators'. Regulator nodes included in this sub-node should be of the format as listed below. -- 2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel