Thread (6 messages) 6 messages, 2 authors, 2020-12-14

Re: [PATCH v1 1/4] devicetree: phy: rockchip-emmc optional add vendor prefix

From: Rob Herring <robh@kernel.org>
Date: 2020-12-14 14:11:43
Also in: linux-devicetree, linux-rockchip, lkml

On Sun, Dec 13, 2020 at 9:00 PM Chris Ruehl [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Update the documentation and add the vendor prefix to the optional
properties referred in vendor-prefixes.yaml.

Signed-off-by: Chris Ruehl <redacted>
---
 .../bindings/phy/rockchip-emmc-phy.txt        | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
index 00aa2d349e55..3a55d8086868 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
@@ -13,14 +13,15 @@ Optional properties:
                access to it), it is strongly suggested.
                See ../clock/clock-bindings.txt for details.
  - clocks: Should have a phandle to the card clock exported by the SDHCI driver.
- - drive-impedance-ohm: Specifies the drive impedance in Ohm.
-                        Possible values are 33, 40, 50, 66 and 100.
-                        If not set, the default value of 50 will be applied.
- - enable-strobe-pulldown: Enable internal pull-down for the strobe line.
-                           If not set, pull-down is not used.
- - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
-                           If not set, the register defaults to 0x4.
-                           Maximum value 0xf.
+ - rockchip,drive-impedance-ohm: Specifies the drive impedance in Ohm.
+                                 Possible values are 33, 40, 50, 66 and 100.
+                                 If not set, the default value of 50 will be
+                                 applied.
You can't change this one, it's already an ABI. Only what just got
queued can be changed.
quoted hunk ↗ jump to hunk
+ - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
+                                    line.  If not set, pull-down is not used.
+ - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
+                                    If not set, the register defaults to 0x4.
+                                    Maximum value 0xf.

 Example:
@@ -37,7 +38,7 @@ grf: syscon@ff770000 {
                reg = <0xf780 0x20>;
                clocks = <&sdhci>;
                clock-names = "emmcclk";
-               drive-impedance-ohm = <50>;
+               rockchip,drive-impedance-ohm = <50>;
                #phy-cells = <0>;
        };
 };
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help