Thread (39 messages) 39 messages, 7 authors, 2020-11-27

Re: [PATCH v6 16/17] RFC: kvm: pass kvm argument to follow_pfn callsites

From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2020-11-20 15:55:29
Also in: dri-devel, kvm, linux-media, linux-mm, linux-samsung-soc, lkml

On 20/11/20 16:44, Daniel Vetter wrote:
quoted
It's a bit of a pity, it's making an API more complex (the point of
gfn_to_pfn_memslot vs gfn_to_pfn is exactly that you don't need a
"struct kvm*" and it's clear that you've already done the lookup into
that struct kvm.
Yeah I noticed that, I think pushing the lookups down should work, but
that's a fairly large-scale change. I didn't want to do that for the
RFC since it would distract from the actual change/goal.
-Daniel
Pushing the lookups down would be worse code and possibly introduce 
TOC/TOU races, so better avoid that.  Your patch is fine. :)

Paolo


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help