Re: [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage

[patch V2 00/13] USB: Cleanup in_interupt/in_irq/in_atomic() usage · Thomas Gleixner <hidden> · 2020-10-19
[patch V2 01/13] USB: sisusbvga: Make console support depend on BROKEN · Thomas Gleixner <hidden> · 2020-10-19
[patch V2 04/13] USB: serial: digi_acceleport: Remove in_interrupt() usage · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 04/13] USB: serial: digi_acceleport: Remove in_interrupt() usage · Johan Hovold <johan@kernel.org> · 2020-10-25
[PATCH v3 04/13 ] USB: serial: digi_acceleport: Remove in_interrupt() usage · Sebastian Andrzej Siewior <bigeasy@linutronix.de> · 2020-10-26
Re: [PATCH v3 04/13 ] USB: serial: digi_acceleport: Remove in_interrupt() usage · Johan Hovold <johan@kernel.org> · 2020-10-27
[patch V2 09/13] USB: host: ehci-pmcmsp: Cleanup usb_hcd_msp_remove() · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 09/13] USB: host: ehci-pmcmsp: Cleanup usb_hcd_msp_remove() · Alan Stern <stern@rowland.harvard.edu> · 2020-10-19
[patch V2 10/13] usb: gadget: pxa27x_udc: Replace in_interrupt() usage in comments · Thomas Gleixner <hidden> · 2020-10-19
[patch V2 06/13] usb: host: isp1362: Replace in_interrupt() usage · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 06/13] usb: host: isp1362: Replace in_interrupt() usage · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2020-10-28
[patch V2 07/13] usbip: Remove in_interrupt() check · Thomas Gleixner <hidden> · 2020-10-19
[patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment · Duncan Sands <duncan.sands@free.fr> · 2020-10-19
[patch V2 08/13] usb: hosts: Remove in_interrupt() from comments · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 08/13] usb: hosts: Remove in_interrupt() from comments · Alan Stern <stern@rowland.harvard.edu> · 2020-10-19
[patch V2 12/13] usb: core: Replace in_interrupt() in comments · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 12/13] usb: core: Replace in_interrupt() in comments · Alan Stern <stern@rowland.harvard.edu> · 2020-10-19
[patch V2 11/13] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 11/13] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments · Alan Stern <stern@rowland.harvard.edu> · 2020-10-19
[patch V2 05/13] usb: xhci: Remove in_interrupt() checks · Thomas Gleixner <hidden> · 2020-10-19
[patch V2 03/13] USB: serial: keyspan_pda: Consolidate room query · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 03/13] USB: serial: keyspan_pda: Consolidate room query · Johan Hovold <johan@kernel.org> · 2020-10-25
[patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage · Thomas Gleixner <hidden> · 2020-10-19
Re: [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage · Johan Hovold <johan@kernel.org> · 2020-10-25
Re: [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage · Sebastian Andrzej Siewior <bigeasy@linutronix.de> · 2020-10-26
Re: [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage · Johan Hovold <johan@kernel.org> · 2020-10-27

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2020-10-26 12:48:00
Also in: linux-omap, linux-samsung-soc, linux-usb, lkml

On 2020-10-25 17:56:47 [+0100], Johan Hovold wrote:

There's a ton of issues with this driver, but this is arguably making
things worse. A line discipline may call write() from just about any
context so we cannot rely on tty being non-NULL here (e.g. PPP).

I wasn't aware of that. I've been looking at the callers each time a
`tty' was passed it looked like a preemptible context (due to mutex /
GFP_KERNEL) and so on.

Johan

Sebastian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help