Re: [patch 05/12] usb: xhci: Remove in_interrupt() checks
From: Mathias Nyman <hidden>
Date: 2020-10-23 13:37:39
Also in:
linux-omap, linux-samsung-soc, linux-usb, lkml
From: Mathias Nyman <hidden>
Date: 2020-10-23 13:37:39
Also in:
linux-omap, linux-samsung-soc, linux-usb, lkml
On 14.10.2020 17.52, Thomas Gleixner wrote:
From: Ahmed S. Darwish <redacted> The usage of in_interrupt() in drivers is phased out for various reasons. xhci_set_hc_event_deq() has an !in_interrupt() check which is pointless because the function is only invoked from xhci_mem_init() which is clearly task context as it does GFP_KERNEL allocations. Remove it. xhci_urb_enqueue() prints a debug message if an URB is submitted after the underlying hardware was suspended. But that warning is only issued when in_interrupt() is true, which makes no sense. Simply return -ESHUTDOWN and be done with it. Signed-off-by: Ahmed S. Darwish <redacted> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <redacted> Cc: Mathias Nyman <mathias.nyman@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 2 +- drivers/usb/host/xhci.c | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-)
Acked-by: Mathias Nyman <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel