Thread (26 messages) 26 messages, 7 authors, 2020-10-23

Re: [patch 07/12] usbip: Remove in_interrupt() check

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2020-10-14 15:45:54
Also in: linux-omap, linux-samsung-soc, linux-usb, lkml

On 10/14/20 8:52 AM, Thomas Gleixner wrote:
quoted hunk ↗ jump to hunk
From: Ahmed S. Darwish <redacted>

The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

usbip_recv() uses in_interrupt() to conditionally print context information
for debugging messages. The value is zero as the function is only called
from various *_rx_loop() kthread functions. Remove it.

Signed-off-by: Ahmed S. Darwish <redacted>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <redacted>
Cc: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org

---
  drivers/usb/usbip/usbip_common.c |    5 -----
  1 file changed, 5 deletions(-)
--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -324,11 +324,6 @@ int usbip_recv(struct socket *sock, void
  	} while (msg_data_left(&msg));
  
  	if (usbip_dbg_flag_xmit) {
-		if (!in_interrupt())
-			pr_debug("%-10s:", current->comm);
-		else
-			pr_debug("interrupt  :");
-
  		pr_debug("receiving....\n");
  		usbip_dump_buffer(buf, size);
  		pr_debug("received, osize %d ret %d size %zd total %d\n",
Looks good to me.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help