Re: [PATCH 4/7] drivers: leds: Add the iEi WT61P803 PUZZLE LED driver
flat view
From: Pavel Machek <hidden>
Date: 2020-09-08 22:22:23
Also in:
linux-hwmon, linux-leds, lkml
Hi!
Add support for the iEi WT61P803 PUZZLE LED driver. Currently only the front panel power LED is supported. This driver depends on the iEi WT61P803 PUZZLE MFD driver. Signed-off-by: Luka Kovacic <luka.kovacic@sartura.hr> Cc: Luka Perkov <luka.perkov@sartura.hr>
+#define CMD_CHAR(x) (char)(x)
Come on... no need to hide this in macro.
*resp_buf = kmalloc(IEI_WT61P803_PUZZLE_BUF_SIZE, GFP_KERNEL); + +
AFAICT you'll happily dereference NULL when kmalloc fails. If it is small, should you just put buffer on stack? Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel