Re: [PATCH 7/7] arm64: dts: marvell: Add a device tree for the iEi Puzzle-M801 board
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-09-05 15:21:42
Also in:
linux-hwmon, linux-leds, lkml
On Sat, Sep 05, 2020 at 03:03:36PM +0200, Luka Kovacic wrote:
quoted hunk ↗ jump to hunk
+&cp0_mdio { + #address-cells = <1>; + #size-cells = <0>; + + status = "okay"; + + ge_phy2: ethernet-phy@2 { + reg = <0>;
Hi Luka The value after the @ should be the same as the reg value. So this should be ge_phy2: ethernet-phy@0
quoted hunk ↗ jump to hunk
+ }; + + ge_phy3: ethernet-phy@3 { + reg = <1>;
And this is: ge_phy2: ethernet-phy@1 This is a general DT rule, so please check the whole file.
quoted hunk ↗ jump to hunk
+&cp0_eth0 { + status = "okay"; + phy-mode = "10gbase-r"; + phys = <&cp0_comphy4 0>; + local-mac-address = [00 50 43 de ff 00];
Does the bootloader overwrite these with per device MAC addresses?
Looking up this OUI i find:
00:50:43 Marvell Semiconductor, Inc.
I'm not sure you should be using that!
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel