On Tue, Sep 1, 2020 at 8:17 AM Kees Cook [off-list ref] wrote:

On Tue, Sep 01, 2020 at 10:16:47AM +0200, Ingo Molnar wrote:

quoted

* Ingo Molnar [off-list ref] wrote:

quoted

* Ingo Molnar [off-list ref] wrote:

quoted

* Kees Cook [off-list ref] wrote:

quoted

On Fri, Aug 21, 2020 at 12:42:41PM -0700, Kees Cook wrote:

quoted

Hi Ingo,

Based on my testing, this is ready to go. I've reviewed the feedback on
v5 and made a few small changes, noted below.

If no one objects, I'll pop this into my tree for -next. I'd prefer it
go via -tip though! :)

Thanks!

I'll pick it up today, it all looks very good now!

One thing I found in testing is that it doesn't handler older LD
versions well enough:

  ld: unrecognized option '--orphan-handling=warn'

Oh! Uhm, yikes. Thanks for noticing this.

quoted

quoted

Could we just detect the availability of this flag, and emit a warning
if it doesn't exist but otherwise not abort the build?

Yeah, I'll respin those patches.

quoted

quoted

This is with:

  GNU ld version 2.25-17.fc23

(At best, this is from 2015 ... but yes, min binutils in 2.23.)

Ah, crap! Indeed arch/powerpc/Makefile wraps this in ld-option.

Uh oh, the ppc vdso uses cc-ldoption which was removed! (I think by
me; let me send patches)  How is that not an error?  Yes, guilty,
officer.
commit 055efab3120b ("kbuild: drop support for cc-ldoption").
Did I not know how to use grep, or?  No, it is
commit f2af201002a8 ("powerpc/build: vdso linker warning for orphan sections")
that is wrong.
-- 
Thanks,
~Nick Desaulniers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel