Re: [PATCH v7 16/25] coresight: allow funnel and replicator drivers to be built as modules
From: Suzuki K Poulose <suzuki.poulose@arm.com>
Date: 2020-08-05 16:02:18
On 08/05/2020 03:54 AM, Tingwei Zhang wrote:
From: Kim Phillips <redacted> Allow to build coresight-funnel and coresight-replicator as modules, for ease of development. - Kconfig becomes a tristate, to allow =m - add funnel_remove and replicator_remove functions, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Leo Yan <redacted> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Russell King <linux@armlinux.org.uk> Signed-off-by: Kim Phillips <redacted> Signed-off-by: Tingwei Zhang <redacted> Tested-by: Mike Leach <redacted>
nit: Please split the changes to multiple drivers into their respective patches. Also, I don't see any harm in merging the "remove multiple init calls" patches with the respective "allow module" for the respective drivers. Otherwise looks good to me. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel