Re: [PATCH v3 1/2] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2020-08-30 14:05:46
Also in:
linux-amlogic, linux-devicetree
Hi Anand, On Sun, Aug 30, 2020 at 3:12 PM Anand Moon [off-list ref] wrote: [...]
+ /* Make sure the rtc irq pin is properly configured as input */
+ rtc_irq_pins: rtc-pin-irq {
+ mux {
+ groups = "GPIOAO_7";
+ function = "gpio_periphs";check meson_g12a_aobus_functions in drivers/pinctrl/meson/pinctrl-meson-g12a.c GPIOAO_7 doesn't support "gpio_periphs", instead I think it should be "gpio_aobus" I'm surprised that you don't seem to be getting errors from the pin controller driver about this. On the other hand you have not attached the full kernel log, so maybe it's in there but hidden somewhere
+ bias-disable;
shouldn't there be output-disable or input-enable here?
quoted hunk ↗ jump to hunk
+ }; + }; + hdmi-connector { compatible = "hdmi-connector"; type = "a";@@ -481,7 +490,8 @@ hdmi_tx_tmds_out: endpoint { &i2c3 { pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>; - pinctrl-names = "default"; + pinctrl-1 = <&rtc_irq_pins>; + pinctrl-names = "default", "gpio_periphs";
I am not expecting this to work because it means that the I2C driver
would have to manage the "gpio_periphs" pin state (but there's no
pinctrl_* call in drivers/i2c/busses/i2c-meson.c)
instead I would try:
&i2c3 {
pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>, <&rtc_irq_pins>;
pinctrl-names = "default";
...
};
or even:
rtc0: rtc@51 {
pinctrl-0 = <&rtc_irq_pins>;
pinctrl-names = "default";
...
};
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel