Thread (50 messages) 50 messages, 4 authors, 2020-09-02

Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3

From: Sylwester Nawrocki <snawrocki@kernel.org>
Date: 2020-08-31 10:35:46
Also in: linux-devicetree, linux-samsung-soc, lkml

Hi,

On 8/31/20 10:38, Krzysztof Kozlowski wrote:
On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski [off-list ref] wrote:
quoted
On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
quoted
The camera's pinctrl configuration is simply empty and not effective.
Remove it to fix dtbs_check warning:

    arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
I think that this was intentional to properly enable support for
mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the
default values if no pinctrl properties are provided. Sylwester, could
you comment?
Indeed it could be intentional... I see now errors:
[   33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19

I wonder why getting an empty pinctrl is needed... maybe the driver
should accept missing pinctrl?
It might have been better to have the pinctrl properties optional, as there
might be boards without the image sensor attached and FIMC could still be 
used in memory-to-memory mode, as Marek pointed out. But it seems too late 
now to change that. The binding defines the pinctrl properties as required 
(Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to
keep them in dtses.

--
Regards,
Sylwester

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help