Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2020-08-31 08:44:44
Also in:
linux-devicetree, linux-samsung-soc, lkml
Hi Krzysztof, On 31.08.2020 10:38, Krzysztof Kozlowski wrote:
On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski [off-list ref] wrote:quoted
On 30.08.2020 15:51, Krzysztof Kozlowski wrote:quoted
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix dtbs_check warning: arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?Indeed it could be intentional... I see now errors: [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19 I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
Please ensure that you have those patches applied: https://patchwork.kernel.org/patch/11707579/ https://patchwork.kernel.org/patch/11707577/ https://patchwork.kernel.org/patch/11705409/ Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel