Re: [PATCH v7 02/10] arm64: hyperv: Add core Hyper-V include files

From
Arnd Bergmann <arnd@arndb.de>
Date
2020-08-24 18:39:07
Also in
linux-arch, linux-efi, linux-hyperv, lkml
Reply to
Michael Kelley, 2020-08-24
On Mon, Aug 24, 2020 at 6:47 PM Michael Kelley [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+
+#define hv_get_simp(val) (val = hv_get_vpreg(HV_REGISTER_SIPP))
+
+#define hv_get_siefp(val) (val = hv_get_vpreg(HV_REGISTER_SIFP))
Macros that modify their arguments are generally a bad idea. Since each one
of these only has a few callers, could you just redefine the x86 version to
use function-style calling conventions and turn them into inline functions?

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (25 messages) 25 messages, 5 authors, last reply 2020-08-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help